Removing need for GH_ACCESS_TOKEN #168
Conversation
There was a problem hiding this comment.
I am pretty sure it is working, but did you test it (=the new release wf) on a tag on your fork? Can you add a link to the corresponding run if it is the case?
Thanks !
(If i were picky, i would point out that we would rather have first line of commit line be in imperative mood :)
|
It was tested live: https://github.com/airbus/scikit-decide/runs/4551726615?check_suite_focus=true. On my repo I have a secret :-) but it is not needed ... It was removed everywhere but this one was forgotten. |
|
Hum... When following your link, i see a workflow crashing 😅 :
So it seems not working actually ? |
|
Ok, i understand now, the link was pointing to the airbus repo (and not @galleon 's fork) and to the release occuring before this PR. So the link was explaining why the PR is needed. |
The token was not in the secrets which causes this job to break.
The secret is not referenced anymore