-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Match with botocore codestyle #952
Conversation
- Trim white spaces in all files - Apply black to aiobotocore, examples, and tests - Apply isort to aiobotocore, examples, and tests
Looks like a comment
On short notice, I realized that flake8-black/black requires Python 3.7 I will probably reuse this PR to bump the Python release too (botocore deprecated Python 3.6 anywhere between 1.25 and 1.27). |
6004f71
to
cfe8315
Compare
Black can not be installed with python 3.6, and since botocore dropped support for this version, we can go the same way for the next release
flake8 fails to run in python 3.7 because the tests/python3.8 path results in sintax errors.
cfe8315
to
b57186c
Compare
Codecov Report
@@ Coverage Diff @@
## master #952 +/- ##
==========================================
- Coverage 86.74% 86.74% -0.01%
==========================================
Files 55 55
Lines 5298 5295 -3
==========================================
- Hits 4596 4593 -3
Misses 702 702
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@thehesiod friendly ping :) |
@gmsantos sorry been absolutely swamped, lets c if we can get this through today |
src_paths = ["aiobotocore", "tests"] | ||
|
||
[tool.black] | ||
line-length = 79 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
man they had to go with 79 chars . we may want to increase this by six (await ) to ensure the lines match up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can try, but idk if this will not change for other cases, like lines around 80-85 (alignment will not be consistent in these cases)
omg my eyes are burning lol, looks good! But we need to bump version. I can do that in another PR |
Description of Change
Relates to #951
During a tentative upgrade of botocore to a newer version, it was really difficult to identify real code changes to formating changes because botocore adopted black and isort in their code base (see boto/botocore#2472).
This PR brings the same codestyle changes to aiobotocore to make it easier to bump botocore afterward.
Assumptions
Since I'm planning to follow up with a bump to botocore, I didn't add it to CHANGES.rst or bumped the version release. Let me know if I need to perform it for this PR too.
Checklist for All Submissions
Checklist when updating botocore and/or aiohttp versions
View rendered .github/pull_request_template.md