8000 Move here the process-related widgets from awb by yakutovicha · Pull Request #211 · aiidalab/aiidalab-home · GitHub
[go: up one dir, main page]

Skip to content

Move here the process-related widgets from awb - #211

Merged
yakutovicha merged 10 commits into
mainfrom
chore/move-here-some-notebooks-from-iwb
Mar 10, 2026
Merged

yakutovicha merged 10 commits into
mainfrom
chore/move-here-some-notebooks-from-iwb

Conversation

@yakutovicha
@yakutovicha yakutovicha commented Dec 4, 2025 •
Copy link
Copy Markdown
Member

fixes #210

In this PR, I move the widgets used by the process_list and process notebooks from AWB to aiidalab-home.
Some widgets are moved, while others are copied to preserve AWB behavior.

I also migrated the corresponding widget tests to aiidalab-home.

@danielhollas danielhollas left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting that we decided to vendor the necessary AWB. I'd prefer if this was done in this PR.

@yakutovicha yakutovicha changed the title Move here some of notebooks from ipywidgets Move here the process-related widgets from ipywidgets Feb 2, 2026
@yakutovicha
yakutovicha requested a review from danielhollas March 9, 2026 19:26
@edan-bainglass
edan-bainglass commented Mar 10, 2026 •
Loading
Copy link
Copy Markdown
Member

I strongly recommend replacing the process list widget with the process table developed by Xing and used in the QE app, or something like it, using the table widget. We can of course do this in a separate PR. I'll open an issue once this is merged.

Comment thread start.py
</td>
</tr>
</table>
<a href="{appbase}/process_list.ipynb" title="List Processes" target="_blank">Process list</a>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWB had two links. Here you only include the process list? What happened to "Follow a process"?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that you include here the process.ipynb notebook from AWB to which "Follow a process" was linked, just not the link.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this was done on purpose. The process.ipynb requires a PK number as a URL argument:

<server-url>/apps/apps/home/process.ipynb?id=2380

If you open it from a link as before, it will be empty, see below:

image

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So how should one use this?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You usually open it from the process_list notebook. You select the process you are interested in, and then it opens the process notebook with pk already assigned.

@yakutovicha yakutovicha changed the title Move here the process-related widgets from ipywidgets Move here the process-related widgets from awb Mar 10, 2026
@edan-bainglass edan-bainglass left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yakutovicha LGTM! Same comment as in aiidalab/aiidalab-widgets-base#720. Please link here if you have that overview doc/issue 🙂🙏

@yakutovicha
yakutovicha merged commit 9988634 into main Mar 10, 2026
4 checks passed
@yakutovicha
yakutovicha deleted the chore/move-here-some-notebooks-from-iwb branch March 10, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move here some notebooks from awb

3 participants

0