8000 Enable ipywidgets 8.x by yakutovicha · Pull Request #207 · aiidalab/aiidalab-home · GitHub
[go: up one dir, main page]

Skip to content

Enable ipywidgets 8.x - #207

Merged
yakutovicha merged 4 commits into
mainfrom
update/support-ipw-8.x
Dec 22, 2025
Merged

yakutovicha merged 4 commits into
mainfrom
update/support-ipw-8.x

Conversation

@yakutovicha
Copy link
Copy Markdown
Member

fix #149

Comment thread setup.cfg Resolved
@danielhollas
Copy link
Copy Markdown
Contributor

I believe this one was a blocker last time we tried this.

aiidalab/aiidalab-docker-stack#512

@yakutovicha
Copy link
Copy Markdown
Member Author

I believe this one was a blocker last time we tried this.

aiidalab/aiidalab-docker-stack#512

No more blockers :)

@edan-bainglass edan-bainglass left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danielhollas danielhollas left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions about the changes

Comment thread home/app_manager.py
ipw.dlink(
(self.app, "available_versions"),
(self.version_selector.version_to_install, "index"),
transform=lambda versions: 0 if versions else None,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little confused here: is 0 an index and therefore the latest version is selected by default? Maybe worth a comment.
(also why was this not necessary before?).

Comment thread home/app_store.py Resolved
Comment thread setup.cfg Resolved
Comment thread setup.cfg Resolved
Co-authored-by: Daniel Hollas <daniel.hollas@bristol.ac.uk>
@yakutovicha
yakutovicha merged commit e054922 into main Dec 22, 2025
3 checks passed
@yakutovicha
yakutovicha deleted the update/support-ipw-8.x branch December 22, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the widgetsnbextension version constraint when issue with ipytree is fixed

3 participants

0