8000 Add loading widgets by edan-bainglass · Pull Request #193 · aiidalab/aiidalab-home · GitHub
[go: up one dir, main page]

Skip to content

Add loading widgets - #193

Merged
edan-bainglass merged 1 commit into
aiidalab:mainfrom
edan-bainglass:add-lazy-loaders
Jan 10, 2025
Merged

edan-bainglass merged 1 commit into
aiidalab:mainfrom
edan-bainglass:add-lazy-loaders

Conversation

@edan-bainglass
Copy link
Copy Markdown
Member

No description provided.

@edan-bainglass edan-bainglass self-assigned this Jan 10, 2025
@superstar54 superstar54 left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danielhollas
Copy link
Copy Markdown
Contributor

Nice. LMK in case you want to release a new version of aiidalab-home.

Just a quick note, it would be good to open an issue to profile why these widgets are so slow and try to optimize them. (e.g. by fetching the code in bulk instead of one-by-one, but that is pure speculation on my part).

@edan-bainglass
edan-bainglass merged commit 66acf99 into aiidalab:main Jan 10, 2025
@danielhollas
Copy link
Copy Markdown
Contributor

Nice. LMK in case you want to release a new version of aiidalab-home.

Ah, I didn't realize that you don't need me for this, you've already released the previous version. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0