8000 Start page: use `ipw.VBox` instead of `ipw.Output` to display apps. by yakutovicha · Pull Request #185 · aiidalab/aiidalab-home · GitHub
[go: up one dir, main page]

Skip to content

Start page: use ipw.VBox instead of ipw.Output to display apps. - #185

Merged
yakutovicha merged 2 commits into
mainfrom
fix/remove-workaround-for-apps-hiding
Dec 2, 2024
Merged

yakutovicha merged 2 commits into
mainfrom
fix/remove-workaround-for-apps-hiding

Conversation

@yakutovicha
Copy link
Copy Markdown
Member

This also allows to remove hotfix to observe collapsing apps.

This also allows to remove hotfix to observe collapsing apps.
@danielhollas danielhollas left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for this cleanup @yakutovicha! My only request is to delete the now unused workaround decorator.

I think this change conflicts with #184 since it touches the same code, I think it would be good to merge this one first, since it might simplify the implementation in #184. CC @edan-bainglass d

Comment thread home/start_page.py Resolved
@yakutovicha
yakutovicha merged commit 045df2e into main Dec 2, 2024
@yakutovicha
yakutovicha deleted the fix/remove-workaround-for-apps-hiding branch December 2, 2024 14:06
@danielhollas
danielhollas restored the fix/remove-workaround-for-apps-hiding branch December 2, 2024 14:16
@edan-bainglass
Copy link
Copy Markdown
Member

@yakutovicha very nice! @danielhollas thanks for the ping. I'll rebase and adjust/clean up.

@danielhollas
danielhollas deleted the fix/remove-workaround-for-apps-hiding branch December 3, 2024 11:50
yakutovicha added a commit to aiidalab/aiidalab-widgets-base that referenced this pull request Aug 27, 2026
`ipw.Output` has caused some display bugs in AiiDAlab before
(aiidalab/aiidalab-home#185), where content written into an `ipw.Output`
failed to render. In this PR, we replace `Output` with `VBox` everywhere,
except for the `bug_report` module.

We also added more tests to check the widget's behaviour better.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0