8000 Fix crash in single_app.ipynb from invalid version by danielhollas · Pull Request #181 · aiidalab/aiidalab-home · GitHub
[go: up one dir, main page]

Skip to content

Fix crash in single_app.ipynb from invalid version - #181

Merged
danielhollas merged 2 commits into
mainfrom
fix/single_app_crash
Nov 19, 2024
Merged

danielhollas merged 2 commits into
mainfrom
fix/single_app_crash

Conversation

@danielhollas
Copy link
Copy Markdown
Contributor

This is the same issue that I recently solved in the aiidalab and aiidalab-registry packages,
see aiidalab/aiidaslab#339 and aiidalab/aiidalab-registry#103 for details.

It did not occur to me that the same issue occurs here right in our AiiDAlab home!

Fixes #180

I'll trigger a rebuild of the Python 3.11 docker image with this branch to test this.

This is the same issue that I recently solved in
the aiidalab and aiidalab-registry packages,
see aiidalab/aiidaslab#339 and aiidalab/aiidalab-registry#103 for details.

It did not occur to me that the same issue
occurs here right in our AiiDAlab home!
Comment thread single_app.ipynb Resolved
@danielhollas
Copy link
Copy Markdown
Contributor Author

@yakutovicha I triggered a new build of pr 455, so a new version of ghcr.io/aiidalab/full-stack:pr-455 with a fix will be available in ~20 minutes.

@danielhollas
Copy link
Copy Markdown
Contributor Author

Ok, I've tested the new image and haven't been able to reproduce the error anymore. 🎉

yakutovicha
yakutovicha previously approved these changes Nov 19, 2024
@yakutovicha yakutovicha left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works, thanks 👍

@danielhollas
danielhollas merged commit d1ae1cc into main Nov 19, 2024
@danielhollas
danielhollas deleted the fix/single_app_crash branch November 19, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

single_app.ipynb crashes with packaging>=22.0

2 participants

0