Repository navigation
Fix crash in single_app.ipynb from invalid version - #181
Merged
Merged
Conversation
danielhollas
force-pushed
the
fix/single_app_crash
branch
from
November 19, 2024 17:56
ca71baa to
431c4ea
Compare
This is the same issue that I recently solved in the aiidalab and aiidalab-registry packages, see aiidalab/aiidaslab#339 and aiidalab/aiidalab-registry#103 for details. It did not occur to me that the same issue occurs here right in our AiiDAlab home!
danielhollas
force-pushed
the
fix/single_app_crash
branch
from
November 19, 2024 18:08
16a874e to
abf0d90
Compare
danielhollas
commented
Nov 19, 2024
Contributor
Author
|
@yakutovicha I triggered a new build of pr 455, so a new version of |
Contributor
Author
|
Ok, I've tested the new image and haven't been able to reproduce the error anymore. 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same issue that I recently solved in the aiidalab and aiidalab-registry packages,
see aiidalab/aiidaslab#339 and aiidalab/aiidalab-registry#103 for details.
It did not occur to me that the same issue occurs here right in our AiiDAlab home!
Fixes #180
I'll trigger a rebuild of the Python 3.11 docker image with this branch to test this.