8000 Disable prompt for appstore and single app page by danielhollas · Pull Request #154 · aiidalab/aiidalab-home · GitHub
[go: up one dir, main page]

Skip to content

Disable prompt for appstore and single app page - #154

Merged
danielhollas merged 1 commit into
mainfrom
disable-prompts-everywhere
Jul 26, 2023
Merged

danielhollas merged 1 commit into
mainfrom
disable-prompts-everywhere

Conversation

@danielhollas
@danielhollas danielhollas commented Jul 18, 2023 •
Copy link
Copy Markdown
Contributor

This is a follow up on #141 where we disabled the alert prompt when leaving the home page. We've been using it for quite a while since and haven't noticed any issues so it's time to apply to other apps / pages.

In the future, we should ideally apply this fix directly in Appmode, but that will require more work so for now here's just a simple hotfix.

Closes #133

@danielhollas
danielhollas marked this pull request as ready for review July 24, 2023 12:38
@danielhollas
Copy link
Copy Markdown
Contributor Author

@unkcpz by the way, if you haven't already, you might want to apply this fix for the QeApp as well...

@yakutovicha yakutovicha left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested - seems to work well. Thanks, @danielhollas!

@danielhollas
danielhollas merged commit 0f6e61a into main Jul 26, 2023
@danielhollas
danielhollas deleted the disable-prompts-everywhere branch July 26, 2023 12:45
@unkcpz
unkcpz commented Jul 27, 2023
Copy link
Copy Markdown
Member

@unkcpz by the way, if you haven't already, you might want to apply this fix for the QeApp as well...

Yes, worth to do it. I think this is also worth to be documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disable the confirmation dialog for static pages

3 participants

0