Repository navigation
Disable prompt for appstore and single app page - #154
Merged
Merged
Conversation
danielhollas
marked this pull request as ready for review
July 24, 2023 12:38
Contributor
Author
|
@unkcpz by the way, if you haven't already, you might want to apply this fix for the QeApp as well... |
yakutovicha
approved these changes
Jul 26, 2023
Member
There was a problem hiding this comment.
Tested - seems to work well. Thanks, @danielhollas!
Member
Yes, worth to do it. I think this is also worth to be documented. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up on #141 where we disabled the alert prompt when leaving the home page. We've been using it for quite a while since and haven't noticed any issues so it's time to apply to other apps / pages.
In the future, we should ideally apply this fix directly in Appmode, but that will require more work so for now here's just a simple hotfix.
Closes #133