8000 Remove not depracated git_setup.ipynb by unkcpz · Pull Request #135 · aiidalab/aiidalab-home · GitHub
[go: up one dir, main page]

Skip to content

Remove not depracated git_setup.ipynb - #135

Merged
yakutovicha merged 1 commit into
mainfrom
chore/xx/purge-git-setup-nb
Mar 1, 2023
Merged

yakutovicha merged 1 commit into
mainfrom
chore/xx/purge-git-setup-nb

Conversation

@unkcpz
@unkcpz unkcpz commented Feb 20, 2023
Copy link
Copy Markdown
Member

@yakutovicha This notebook is not used anymore, correct?

@danielhollas
Copy link
Copy Markdown
Contributor

Hmm, this actually looks kinda useful. Perhaps this could be a part of the new "Settings" tab that we've discussed as part of making AWB into a library.

@unkcpz
unkcpz commented Feb 20, 2023
Copy link
Copy Markdown
Member Author

Why do you think it is useful? I think it basically provides for AiiDAlab user git access but in my opinion, the "production" AiiDAlab user doesn't need this and we (developers) need git setup but since we introduce the aiidalab-launch to start the local development environment this again not been used.

@danielhollas
Copy link
Copy Markdown
Contributor

Yeah, I guess for production this shouldn't be there.

@unkcpz
unkcpz requested a review from danielhollas February 21, 2023 17:25
@danielhollas danielhollas left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please wait what @yakutovicha has to say before we delete this.

@yakutovicha yakutovicha left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, yeah. That is something extreeeeemely old and not used anymore.

@yakutovicha
yakutovicha merged commit 1548a66 into main Mar 1, 2023
@yakutovicha
yakutovicha deleted the chore/xx/purge-git-setup-nb branch March 1, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0