8000 Fix/support not registered apps and improve handling of registry server cannot be reached by csadorf · Pull Request #71 · aiidalab/aiidalab-home · GitHub
[go: up one dir, main page]

Skip to content

Fix/support not registered apps and improve handling of registry server cannot be reached - #71

Merged
csadorf merged 2 commits into
developfrom
fix/support-not-registered-apps-and-improve-handling-of-registry-server-cannot-be-reached
Sep 23, 2021
Merged

csadorf merged 2 commits into
developfrom
fix/support-not-registered-apps-and-improve-handling-of-registry-server-cannot-be-reached

Conversation

@csadorf
@csadorf csadorf commented Sep 22, 2021
Copy link
Copy Markdown
Member

Related to aiidalab/aiidalab#222 .

@csadorf
csadorf force-pushed the fix/support-not-registered-apps-and-improve-handling-of-registry-server-cannot-be-reached branch from a599338 to 8cf4e72 Compare September 22, 2021 15:06
@csadorf
csadorf requested a review from yakutovicha September 22, 2021 15:08
@csadorf
csadorf commented Sep 22, 2021 •
Copy link
Copy Markdown
Member Author

Test with aiidalab/aiidalab#222 .

@yakutovicha yakutovicha left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @csadorf.

The code looks good. I've also tested the changes locally, and everything works without problems.

@csadorf
csadorf merged commit 84bed16 into develop Sep 23, 2021
@csadorf
csadorf deleted the fix/support-not-registered-apps-and-improve-handling-of-registry-server-cannot-be-reached branch September 23, 2021 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0