8000 Remove the "Update required" state which is now obsolete. by yakutovicha · Pull Request #69 · aiidalab/aiidalab-home · GitHub
[go: up one dir, main page]

Skip to content

Remove the "Update required" state which is now obsolete. - #69

Merged
yakutovicha merged 1 commit into
developfrom
update/remove-update-required-state
Sep 15, 2021
Merged

yakutovicha merged 1 commit into
developfrom
update/remove-update-required-state

Conversation

@yakutovicha
Copy link
Copy Markdown
Member

No description provided.

@yakutovicha
yakutovicha requested a review from csadorf September 14, 2021 16:47
@csadorf csadorf left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updates_available trait is also used in the home/app_manager.py and home/start_page.py modules. Can you make sure to remove the use of this state there as well?

@yakutovicha
yakutovicha commented Sep 15, 2021 •
Copy link
Copy Markdown
Member Author

The updates_available trait is also used in the home/app_manager.py and home/start_page.py modules. Can you make sure to remove the use of this state there as well?

I am a bit confused here. I believe we want to keep the "Updates available" state. I only removed the "Updates required".

I think the updates_available trait is correctly used.

@yakutovicha
yakutovicha requested a review from csadorf September 15, 2021 09:24
@yakutovicha
yakutovicha merged commit d54d12d into develop Sep 15, 2021
@yakutovicha
yakutovicha deleted the update/remove-update-required-state branch September 15, 2021 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0