Repository navigation
Skip requirements with inapplicable markers, vol. 2 - #561
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #561 +/- ##
==========================================
+ Coverage 79.23% 79.26% +0.02%
==========================================
Files 18 18
Lines 1763 1765 +2
==========================================
+ Hits 1397 1399 +2
Misses 366 366
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Follow-up to #532 _find_incompatibilities_python now skips any requirement whose marker doesn't 8000 apply before looking up the package. A requirement like pywin32; sys_platform == 'win32' on Linux no longer makes the app incompatible.
danielhollas
force-pushed
the
claude-fix-2
branch
from
October 19, 2026 08:06
bb86432 to
6c141c7
Compare
danielhollas
marked this pull request as ready for review
October 19, 2026 08:30
danielhollas
commented
Oct 19, 2026
| if requirement.marker and not requirement.marker.evaluate(): | ||
| continue | ||
| pkg = get_package_by_name(packages, requirement.name) | ||
| if pkg is None or not pkg.fulfills(requirement): |
Contributor
Author
There was a problem hiding this comment.
pkg.fullfils already has the correct marker logic, but I missed that this or expression is short-circuited if the package is not present in the current python environment.
Contributor
Author
Good catch by Claude indeed. 😅 I'm in the middle of existential crisis, but at least |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #532, turns out I haven't been thorough enough and that PR did not fully worked in all cases.
_find_incompatibilities_python now skips any requirement whose marker doesn't apply before looking up the package. A requirement like
pywin32; sys_platform == 'win32'on Linux no longer makes the app incompatible.Fixes point 3 in #559
Testing
I've tested manually by adding
pywin32; sys_platform == 'win32'as a dependency and seeing the app became incompatible on main branch, which remains compatible on this PR.