8000 Don't pass None as stdout to app install method by danielhollas · Pull Request #560 · aiidalab/aiidalab · GitHub
[go: up one dir, main page]

Skip to content

Don't pass None as stdout to app install method - #560

Merged
danielhollas merged 1 commit into
mainfrom
claude-fix-1
Oct 19, 2026
Merged

danielhollas merged 1 commit into
mainfrom
claude-fix-1

Conversation

@danielhollas
Copy link
Copy Markdown
Contributor

install_app() and update_app() would crash when no stdout is passed. Both default stdout=None and pass it through, overriding install()'s default of sys.stdout. The first stdout.write() then raises AttributeError. reinstall_app() already uses stdout or sys.stdout; the other two don't.

Also fixes a missing f-string

Fixes items 2 and 10 from #559

install_app() and update_app() would crash when no stdout is passed.
Both default stdout=None and pass it through, overriding install()'s default of sys.stdout.
The first stdout.write() then raises AttributeError.
reinstall_app() already uses stdout or sys.stdout; the other two don't.
@codecov
codecov Bot commented Oct 18, 2026
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 79.23%. Comparing base (e407596) to head (02931b9).

Files with missing lines Patch % Lines
aiidalab/app.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #560   +/-   ##
=======================================
  Coverage   79.23%   79.23%           
=======================================
  Files          18       18           
  Lines        1763     1763           
=======================================
  Hits         1397     1397           
  Misses        366      366           
Flag Coverage Δ
py-3.12 79.23% <0.00%> (ø)
py-3.14 79.14% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@edan-bainglass edan-bainglass left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@danielhollas
danielhollas merged commit 326e214 into main Oct 19, 2026
9 checks passed
@danielhollas
danielhollas deleted the claude-fix-1 branch October 19, 2026 08:06
@danielhollas danielhollas added the bug Something isn't working label Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0