Repository navigation
Don't pass None as stdout to app install method - #560
Merged
Merged
Conversation
install_app() and update_app() would crash when no stdout is passed. Both default stdout=None and pass it through, overriding install()'s default of sys.stdout. The first stdout.write() then raises AttributeError. reinstall_app() already uses stdout or sys.stdout; the other two don't.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #560 +/- ##
=======================================
Coverage 79.23% 79.23%
=======================================
Files 18 18
Lines 1763 1763
=======================================
Hits 1397 1397
Misses 366 366
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
install_app() and update_app() would crash when no stdout is passed. Both default stdout=None and pass it through, overriding install()'s default of sys.stdout. The first stdout.write() then raises AttributeError. reinstall_app() already uses stdout or sys.stdout; the other two don't.
Also fixes a missing f-string
Fixes items 2 and 10 from #559