Repository navigation
Support zip archives when installing apps - #566
Draft
danielhollas wants to merge 4 commits into
Draft
danielhollas wants to merge 4 commits into
danielhollas wants to merge 4 commits into
Conversation
8000
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## claude-fix-5 #566 +/- ##
================================================
+ Coverage 79.26% 80.02% +0.75%
================================================
Files 18 18
Lines 1765 1767 +2
================================================
+ Hits 1399 1414 +15
+ Misses 366 353 -13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
danielhollas
force-pushed
the
claude-fix-6
branch
from
October 19, 2026 08:06
bace861 to
2e10b2c
Compare
Don't check compatibility of apps that are not installed, and return None when the installed version is not a registry release. Previously both cases set `compatible` to False, so the home app showed every uninstalled app as incompatible. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Previously any installed version that differed from the latest release was reported as UPDATE_AVAILABLE, so an app installed at a newer version was offered a downgrade. Versions that are not PEP 440 compliant cannot be ordered and keep the old behaviour. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
requests.get() has no default timeout, so a server that stopped responding would hang app installation indefinitely. Use a 60 s timeout for connecting and for each read, which still allows slow downloads of large archives. Also drop stream=True, which had no effect since the full response content was read into memory anyway
App installation only extracted tar archives, even though the app metadata is read via fetch.py, which also supports zip. So an app with a zip release URL showed up correctly but failed to install. Reuse the fetch.py helpers to extract local and HTTPS archives, so that installation handles the same archives, with the same safety filters, as metadata parsing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
danielhollas
force-pushed
the
claude-fix-6
branch
from
October 19, 2026 08:39
2e10b2c to
127510f
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fully Claude, need to test
App installation only extracted tar archives, even though the app metadata is read via fetch.py, which also supports zip. So an app with a zip release URL showed up correctly but failed to install. Reuse the fetch.py helpers to extract local and HTTPS archives, so that installation handles the same archives, with the same safety filters, as metadata parsing.