8000 Support zip archives when installing apps by danielhollas · Pull Request #566 · aiidalab/aiidalab · GitHub
[go: up one dir, main page]

Skip to content

Support zip archives when installing apps - #566

Draft
danielhollas wants to merge 4 commits into
claude-fix-5from
claude-fix-6
Draft

danielhollas wants to merge 4 commits into
claude-fix-5from
claude-fix-6

Conversation

@danielhollas
Copy link
Copy Markdown
Contributor

Fully Claude, need to test


App installation only extracted tar archives, even though the app metadata is read via fetch.py, which also supports zip. So an app with a zip release URL showed up correctly but failed to install. Reuse the fetch.py helpers to extract local and HTTPS archives, so that installation handles the same archives, with the same safety filters, as metadata parsing.

@codecov
codecov Bot commented Oct 18, 2026 •
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.02%. Comparing base (f828875) to head (127510f).
⚠️ Report is 6 commits behind head on claude-fix-5.

Additional details and impacted files
@@               Coverage Diff                @@
##           claude-fix-5     #566      +/-   ##
================================================
+ Coverage         79.26%   80.02%   +0.75%     
================================================
  Files                18       18              
  Lines              1765     1767       +2     
================================================
+ Hits               1399     1414      +15     
+ Misses              366      353      -13     
Flag Coverage Δ
py-3.12 80.02% <100.00%> (+0.75%) ⬆️
py-3.14 79.93% <100.00%> (+0.76%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

danielhollas and others added 4 commits October 19, 2026 10:39
Don't check compatibility of apps that are not installed, and return
None when the installed version is not a registry release. Previously
both cases set `compatible` to False, so the home app showed every
uninstalled app as incompatible.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Previously any installed version that differed from the latest release
was reported as UPDATE_AVAILABLE, so an app installed at a newer
version was offered a downgrade. Versions that are not PEP 440
compliant cannot be ordered and keep the old behaviour.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
requests.get() has no default timeout, so a server that stopped
responding would hang app installation indefinitely. Use a 60 s timeout
for connecting and for each read, which still allows slow downloads of
large archives.

Also drop stream=True, which had no effect since the full response
content was read into memory anyway
App installation only extracted tar archives, even though the app
metadata is read via fetch.py, which also supports zip. So an app with
a zip release URL showed up correctly but failed to install. Reuse the
fetch.py helpers to extract local and HTTPS archives, so that
installation handles the same archives, with the same safety filters,
as metadata parsing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@danielhollas danielhollas added the enhancement New feature or request label Oct 26, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0