Repository navigation
Fix schema versions - #506
Conversation
18f455f to
8c7dc60
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #506 +/- ##
==========================================
+ Coverage 72.23% 72.42% +0.18%
==========================================
Files 18 18
Lines 1628 1650 +22
==========================================
+ Hits 1176 1195 +19
- Misses 452 455 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@danielhollas tests pass. If you agree with this change, I will update the relevant repos accordingly. Please also address my questions in #505 w.r.t commit pinning 🙏 |
|
@edan-bainglass tbh I am not sure I am a fan of this change, it seems overly complicated, and at the same time restricts on how the citations must look like. What if I want to cite something that's not a journal article, or doesn't have a DOI? I liked your original idea of having citation as a string, and a separate "citation_url" field that we'll convert to a link. What do you think? |
a02da33 to
6589e43
Compare
Thanks @danielhollas. I'd like to support both. See last commit 🙏 |
There was a problem hiding this comment.
Thanks, this looks reasonable by a quick review while enjoying sunny Scotland :-)
|
@edan-bainglass once you update this PR and merge it, you can then make a release by checking out the main branch (don't forget to pull latest changes) and run: ❯ bumpver update --dry --patch
INFO - fetching tags from remote (to turn off use: -n / --no-fetch)
INFO - Latest version from VCS tag: v26.05.0
INFO - Working dir version : v26.05.0
INFO - Old Version: v26.05.0
INFO - New Version: v26.05.1
--- aiidalab/__init__.py
+++ aiidalab/__init__.py
@@ -4,5 +4,5 @@
__all__ = ["DEVELOP_MODE"]
-__version__ = "26.5.0"
+__version__ = "26.5.1"
--- pyproject.toml
+++ pyproject.toml
@@ -111,7 +111,7 @@
disallow_any_generics = false
[tool.bumpver]
-current_version = "v26.05.0"
+current_version = "v26.05.1"
version_pattern = "v0Y.0M.PATCH[PYTAGNUM]"
commit_message = "Bump version {old_version} -> {new_version}"
commit = trueRemoving the |
0da5d04 to
f72f1f2
Compare
#499 didn't fully handle citations correctly/safely. Here, I add a proper Citation schema and update the handler (backend/frontend).
Schemas are pinned for now to the involved branches (here, in the registry repo, and in the QE app, which I'm using as a tester). Once all is well, schemas should pin to... TBD (see#505).
Update
This PR adds dedicated dataclasses to represent two citation flavors:
Citations are consumed via a either a plugin's
[aiidalab]or[metadata]sections in an app's setup.cfg (aiidalab first):Citations can be overridden via apps.yaml (no change here).
Example from the QE app: