8000 feat: add more BIP85 apps by aeitwoen · Pull Request #387 · agntn/keys · GitHub
[go: up one dir, main page]

Skip to content

feat: add more BIP85 apps - #387

Merged
oritwoen merged 3 commits into
mainfrom
feat/bip85-apps
Nov 17, 2026
Merged

oritwoen merged 3 commits into
mainfrom
feat/bip85-apps

Conversation

@aeitwoen
@aeitwoen aeitwoen commented Nov 16, 2026 •
Copy link
Copy Markdown
Collaborator

Closes #386

This gives @agntn/keys/bip85 and keys_bip85_derive base64 and base85 passwords, Nostr nsec keys and dice, which roll 0 to 5 on six sides because the spec counts from zero.


Read this PR faster    Follow each request

@aeitwoen
aeitwoen requested a review from oritwoen as a code owner November 16, 2026 23:43
@aeitwoen aeitwoen self-assigned this Nov 16, 2026
@coldtea-pr-lens
coldtea-pr-lens Bot commented Nov 16, 2026 •
Copy link
Copy Markdown
  • Redraw · drawn at 1308b20, the branch has moved on

Architecture

Walkthrough of BIP85 passwords, dice and Nostr key derivation, in six steps

Read this PR faster

Inside the changed components — 1 view

Component view — BIP85 Derivation Pipeline

Core BIP85 derivation engine and cryptographic codec dependencies

Architecture view of Component view — BIP85 Derivation Pipeline in agntn/keys

Data flow

Data flow diagram for agntn/keys at 1308b20

Follow each request


Review

1 finding on the diff · reviewed 1308b20

Tip

The diagrams are links. Click one to open it on the canvas, then press W or click play to walk through the change

🪧 More tips
  • Run npx skills add coldteadotai/pr-lens, then tell your coding agent: "Diagram the change you just made with PR Lens and attach it to the pull request."
  • Run npx @coldtea/pr-lens-cli analyze --base origin/main on a branch, then npx @coldtea/pr-lens-cli render .pr-lens/graph.json. Same lenses, your own model key, before the pull request exists
  • Click the link under each diagram to open it on a canvas you can zoom, pan and step through
  • Open a diagram on the canvas, the 8000 n press W or click play to walk through the change one step at a time
  • The CLI's render reads .github/pr-lens.yml and applies your renames, exclusions and lane pins at draw time
  • Set github.comment.collapsed: true in .github/pr-lens.yml to fold the comment behind one View architecture… row. Drawing still runs as before
  • Set github.draw: on-demand in .github/pr-lens.yml and PR Lens stops drawing pull requests on its own. Comment @pr-lens draw on a pull request when you want that one drawn
  • Add .github/workflows/pr-lens.yml with coldteadotai/pr-lens/packages/action@v0 and your model provider's key as its api-key to run PR Lens from your own CI. Any /chat/completions endpoint works
  • After a push, tick Redraw to draw the latest commit
  • Switch GitHub to dark mode and the diagrams follow. The moving dots are this pull request's data in motion
  • Set github.description: false in .github/pr-lens.yml to stop PR Lens adding buttons to your PR descriptions

Thanks for using PR Lens! It's free for OSS. If it helped, a star helps other teams find it.  Star PR Lens on GitHub

@chatgpt-codex-connector
chatgpt-codex-connector Bot commented Nov 16, 2026 •
Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T23:45:01.514430Z 1308b20 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Comment thread src/tool-operations/bip85.ts Resolved
@oritwoen
oritwoen merged commit aeacb83 into main Nov 17, 2026
2 checks passed
@oritwoen
oritwoen deleted the feat/bip85-apps branch November 17, 2026 00:42
@github-actions github-actions Bot mentioned this pull request Nov 16, 2026
@github-actions github-actions Bot mentioned this pull request Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add the remaining BIP85 applications

2 participants

0