8000 refactor: drop the Arweave round trip by aeitwoen · Pull Request #313 · agntn/keys · GitHub
[go: up one dir, main page]

Skip to content

refactor: drop the Arweave round trip - #313

Merged
oritwoen merged 1 commit into
mainfrom
feat/arweave-canonical-base64
Oct 19, 2026
Merged

oritwoen merged 1 commit into
mainfrom
feat/arweave-canonical-base64

Conversation

@aeitwoen
Copy link
Copy Markdown
Collaborator

Closes #300

decodeModulus quits encoding an Arweave modulus back just to see if the text survives, since @agntn/encodings 0.1.2 refuses stray bits by itself. A one-off local run over 200k random strings couldn't get the old and new checks to disagree.

@aeitwoen
aeitwoen requested a review from oritwoen as a code owner October 19, 2026 17:20
@aeitwoen aeitwoen self-assigned this Oct 19, 2026
@coldtea-pr-lens
coldtea-pr-lens Bot commented Oct 19, 2026 •
Copy link
Copy Markdown

Architecture

Architecture diagram for agntn/keys at 41f3977

Play the walkthrough


Data flow

No data-flow sequence changed in this PR.


Review

✨ Nothing flagged · reviewed 41f3977


Tip

The CLI's render reads .github/pr-lens.yml and applies your renames, exclusions and lane pins at draw time

🪧 More tips
  • Run npx skills add coldteadotai/pr-lens, then tell your coding agent: "Diagram the change you just made with PR Lens and attach it to the pull request."
  • Run npx @coldtea/pr-lens-cli analyze --base origin/main on a branch, then npx @coldtea/pr-lens-cli render .pr-lens/graph.json. Same lenses, your own model key, before the pull request exists
  • Click the link under each diagram to open it on a canvas you can zoom, pan and step through
  • The diagrams are links. Click one to open it on the canvas, then press W or click play to walk through the change
  • Open a diagram on the canvas, then press W or click play to walk through the change one step at a time
  • Set github.comment.collapsed: true in .github/pr-lens.yml to fold the comment behind one View architecture and data flow row. Drawing still runs as before
  • Set github.draw: on-demand in .github/pr-lens.yml and PR Lens stops drawing pull requests on its own. Comment @pr-lens draw on a pull request when you want that one drawn
  • Add .github/workflows/pr-lens.yml with coldteadotai/pr-lens/packages/action@v0 and your model provider's key as its api-key to run PR Lens from your own CI. Any /chat/completions endpoint works
  • After a push, tick Redraw to draw the latest commit
  • Switch GitHub to dark mode and the diagrams follow. The moving dots are this pull request's data in motion

Thanks for using PR Lens! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out on X, Bluesky, Mastodon, Reddit or LinkedIn

@chatgpt-codex-connector
chatgpt-codex-connector Bot commented Oct 19, 2026 •
Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Stat 8000 us Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T17:21:07.291535Z 41f3977 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@oritwoen
oritwoen merged commit 375e7bb into main Oct 19, 2026
3 checks passed
@oritwoen
oritwoen deleted the feat/arweave-canonical-base64 branch October 19, 2026 17:23
This was referenced Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use canonical base64 decoding for Arweave moduli

2 participants

0