8000 refactor: pack executor args by aeitwoen · Pull Request #312 · agntn/keys · GitHub
[go: up one dir, main page]

Skip to content

refactor: pack executor args - #312

Merged
oritwoen merged 1 commit into
mainfrom
refactor/executor-options
Oct 19, 2026
Merged

oritwoen merged 1 commit into
mainfrom
refactor/executor-options

Conversation

@aeitwoen
Copy link
Copy Markdown
Collaborator

Closes #310

scanHdWallet took twelve positional arguments, and a Monero test fed deriveWallet five undefineds in a row like blanks on a form. This gives each executor (value, options) instead, taking max-params at 2 from 57 hits to zero.

@aeitwoen
aeitwoen requested a review from oritwoen as a code owner October 19, 2026 15:56
@aeitwoen aeitwoen self-assigned this Oct 19, 2026
@coldtea-pr-lens
coldtea-pr-lens Bot commented Oct 19, 2026 •
Copy link
Copy Markdown

Architecture

Architecture diagram for agntn/keys at 2798ea7

Play the walkthrough

Inside the changed components — 1 view

Component view — Tool Operations Dispatch

Internal dispatch between tool definition wrappers and operation handlers.

Architecture view of Component view — Tool Operations Dispatch in agntn/keys

Data flow

Data flow diagram for agntn/keys at 2798ea7

Follow each request


Review

✨ Nothing flagged · reviewed 2798ea7


Tip

Run npx @coldtea/pr-lens-cli analyze --base origin/main on a branch, then npx @coldtea/pr-lens-cli render .pr-lens/graph.json. Same lenses, your own model key, before the pull request exists

🪧 More tips
  • Run npx skills add coldteadotai/pr-lens, then tell your coding agent: "Diagram the change you just made with PR Lens and attach it to the pull request."
  • Click the link under each diagram to open it on a canvas you can zoom, pan and step through
  • The diagrams are links. Click one to open it on the canvas, then press W or click play to walk through the change
  • Open a diagram on the canvas, then press W or click play to walk through the change one step at a time
  • The CLI's render reads .github/pr-lens.yml and applies your renames, exclusions and lane pins at draw time
  • Set github.comment.collapsed: true in .github/pr-lens.yml to fold the comment behind one View architecture and data flow row. Drawing still runs as before
  • Set github.draw: on-demand in .github/pr-lens.yml and PR Lens stops drawing pull requests on its own. Comment @pr-lens draw on a pull request when you want that one drawn
  • Add .github/workflows/pr-lens.yml with coldteadotai/pr-lens/packages/action@v0 and your model provider's key as its api-key to run PR Lens from your own CI. Any /chat/completions endpoint works
  • After a push, tick Redraw to draw the latest commit
  • Switch GitHub to dark mode and the diagrams follow. The moving dots are this pull request's data in motion

Thanks for using PR Lens! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out on X, Bluesky, Mastodon, Reddit or LinkedIn

@chatgpt-codex-connector
chatgpt-codex-connector Bot commented Oct 19, 2026 •
Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T15:59:00.535600Z 2798ea7 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@oritwoen
oritwoen merged commit afe2bbf into main Oct 19, 2026
3 checks passed
@oritwoen
oritwoen deleted the refactor/executor-options branch October 19, 2026 17:07
@github-actions github-actions Bot mentioned this pull request Oct 19, 2026
@github-actions github-actions Bot mentioned this pull request Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pass executor arguments as one options object

2 participants

0