FFFF refactor: split executors by domain by aeitwoen · Pull Request #292 · agntn/keys · GitHub
[go: up one dir, main page]

Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ The lint scripts build first, because the Pi and OMP extensions take their tool

## Agent tools

- One `defineTool` per tool in `src/tools.ts`, with its executor in `src/tool-operations.ts`. `keys mcp`, the docs `/mcp`, Pi and OMP all serve that list, so a fix never lands on one surface only.
- One `defineTool` per tool in `src/tools.ts`, with its executor in the domain module under `src/tool-operations/` that `index.ts` re-exports. Shared argument readers live in `arguments.ts` and the chain and network ones in `blockchain.ts`. Look there before you write another `requiredString`. `keys mcp`, the docs `/mcp`, Pi and OMP all serve that list, so a fix never lands on one surface only.
- Schemas in `src/tool-schemas.ts` take `Type` from `@agntn/tools`, never a bare `typebox` import, which OMP rewrites to its own facade. Every root is a plain object without `oneOf`, and a `pattern` stays portable across JSON Schema consumers. Unicode property escapes belong in the executor.
- Executors compose public library capabilities and keep their own checks for callers that skip the schema. A blank optional name reads as omitted, while passphrases keep blank and whitespace values.
- Secret input never lands in an error or in structured details.
Expand Down
2 changes: 1 addition & 1 deletion build.config.ts
7407
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export default defineBuildConfig({
"./src/index.ts",
"./src/cli.ts",
"./src/mcp.ts",
"./src/tool-operations.ts",
"./src/tool-operations/index.ts",
"./src/tools.ts",
"./src/utils/bip32/index.ts",
"./src/utils/bip322/index.ts",
Expand Down
Loading
Loading
0