8000 refactor: share an ed25519 chain base by aeitwoen · Pull Request #291 · agntn/keys · GitHub
[go: up one dir, main page]

Skip to content

refactor: share an ed25519 chain base - #291

Merged
oritwoen merged 1 commit into
mainfrom
refactor/ed25519-chain-base
Oct 14, 2026
Merged

oritwoen merged 1 commit into
mainfrom
refactor/ed25519-chain-base

Conversation

@aeitwoen
Copy link
Copy Markdown
Collaborator

AbstractEd25519Blockchain gives the six ed25519 chains one copy of their key and signing boilerplate instead of six, and Solana loses a try/catch around a verify that never throws. Polkadot and Stellar keep just their quirks, <Bytes> and SEP-53.

@aeitwoen
aeitwoen requested a review from oritwoen as a code owner October 14, 2026 21:47
@aeitwoen aeitwoen self-assigned this Oct 14, 2026
@coldtea-pr-lens
coldtea-pr-lens Bot commented Oct 14, 2026 •
Copy link
Copy Markdown

Nothing flagged · reviewed 0ae558f


Architecture

Architecture diagram for agntn/keys at 0ae558f

Play the walkthrough


Data flow

No data-flow sequence changed in this PR.


Tip

Set github.draw: on-demand in .github/pr-lens.yml and PR Lens stops drawing pull requests on its own. Comment @pr-lens draw on a pull request when you want that one drawn

🪧 More tips
  • Run npx skills add coldteadotai/pr-lens, then tell your coding agent: "Diagram the change you just made with PR Lens and attach it to the pull request."
  • Run npx @coldtea/pr-lens-cli analyze --base origin/main on a branch, then npx @coldtea/pr-lens-cli render .pr-lens/graph.json. Same lenses, your own model key, before the pull request exists
  • Click the link under each diagram to open it on a canvas you can zoom, pan and step through
  • The diagrams are links. Click one to open it on the canvas, then press W or click play to walk through the change
  • Open a diagram on the canvas, then press W or click play to walk through the change one step at a time
  • The CLI's render reads .github/pr-lens.yml and applies your renames, exclusions and lane pins at draw time
  • Set github.comment.collapsed: true in .github/pr-lens.yml to fold the comment behind one View architecture and data flow row. Drawing still runs as before
  • Add .github/workflows/pr-lens.yml with coldteadotai/pr-lens/packages/action@v0 and your model provider's key as its api-key to run PR Lens from your own CI. Any /chat/completions endpoint works
  • After a push, tick Redraw to draw the latest commit
  • Switch GitHub to dark mode and the diagrams follow. The moving dots are this pull request's data in motion

Thanks for using PR Lens! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

@chatgpt-codex-connector
chatgpt-codex-connector Bot commented Oct 14, 2026 •
Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-14T21:49:08.403264Z 0ae558f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@oritwoen
oritwoen merged commit 3836693 into main Oct 14, 2026
3 checks passed
@oritwoen
oritwoen deleted the refactor/ed25519-chain-base branch October 14, 2026 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0