8000 feat: add Monero subaddresses and payment IDs by oritwoen · Pull Request #286 · agntn/keys · GitHub
[go: up one dir, main page]

Skip to content

feat: add Monero subaddresses and payment IDs - #286

Merged
oritwoen merged 1 commit into
mainfrom
feat/monero-subaddresses
Oct 12, 2026
Merged

oritwoen merged 1 commit into
mainfrom
feat/monero-subaddresses

Conversation

@oritwoen
Copy link
Copy Markdown
Member

Closes #274

This gives Monero its 8... subaddresses from a view key and two indices, plus integrated addresses with a payment ID. The spend key never enters that math, so it gets to stay home the whole time.

@oritwoen oritwoen self-assigned this Oct 12, 2026
@coldtea-pr-lens
coldtea-pr-lens Bot commented Oct 12, 2026 •
Copy link
Copy Markdown

Nothing flagged · reviewed b97a554


Architecture

Architecture diagram for agntn/keys at b97a554

Play the walkthrough


Inside the changed components — 2 views

Component view — Tool operations

Tool schema validation and wallet dispatching for Monero subaddress indices and integrated address payment IDs.

Architecture view of Component view — Tool operations in agntn/keys

Component view — Monero blockchain engine

Ed25519 scalar derivation, block base58 formatting, and validation across standard, subaddress, and integrated formats.

Architecture view of Component view — Monero blockchain engine in agntn/keys

Data flow

Data flow diagram for agntn/keys at b97a554

Follow each request


The other flows — 1 sequence

Generating an integrated address

Sequence diagram of Generating an integrated address in agntn/keys

Tip

Open a diagram on the canvas, then press W or click play to walk through the change one step at a time

🪧 More tips
  • Run npx skills add coldteadotai/pr-lens, then tell your coding agent: "Diagram the change you just made with PR Lens and attach it to the pull request."
  • Run npx @coldtea/pr-lens-cli analyze --base origin/main on a branch, then npx @coldtea/pr-lens-cli render .pr-lens/graph.json. Same lenses, your own model key, before the pull request exists
  • Click the link under each diagram to open it on a canvas you can zoom, pan and step through
  • The diagrams are links. Click one to open it on the canvas, then press W or click play to walk through the change
  • The CLI's render reads .github/pr-lens.yml and applies your renames, exclusions and lane pins at draw time
  • Set github.comment.collapsed: true in .github/pr-lens.yml to fold the comment behind one View architecture and data flow row. Drawing still runs as before
  • Set github.draw: on-demand in .github/pr-lens.yml and PR Lens stops drawing pull requests on its own. Comment @pr-lens draw on a pull request when you want that one drawn
  • Add .github/workflows/pr-lens.yml with coldteadotai/pr-lens/packages/action@v0 and your model provider's key as its api-key to run PR Lens from your own CI. Any /chat/completions endpoint works
  • After a push, tick Redraw to draw the latest commit
  • Switch GitHub to dark mode and the diagrams follow. The moving dots are this pull request's data in motion

Thanks for using PR Lens! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

@chatgpt-codex-connector
chatgpt-codex-connector Bot commented Oct 12, 2026 •
Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-12T20:00:01.203167Z b97a554 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@oritwoen
oritwoen merged commit 001488e into main Oct 12, 2026
3 checks passed
@oritwoen
oritwoen deleted the feat/monero-subaddresses branch October 12, 2026 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Derive Monero subaddresses and integrated addresses

1 participant

0