8000 test: drop tautological assertions by aeitwoen · Pull Request #283 · agntn/keys · GitHub
[go: up one dir, main page]

Skip to content

test: drop tautological assertions - #283

Merged
oritwoen merged 1 commit into
mainfrom
test/drop-tautologies
Oct 12, 2026
Merged

oritwoen merged 1 commit into
mainfrom
test/drop-tautologies

Conversation

@aeitwoen
Copy link
Copy Markdown
Collaborator

Eleven HD tests stayed green with Bitcoin seed misspelled inside @scure/bip32, since they built their expected keys from the very calls under test. This takes those keys from Trezor's published seeds and bip_utils, which has no noble or scure inside.

@aeitwoen
aeitwoen requested a review from oritwoen as a code owner October 12, 2026 17:28
@aeitwoen aeitwoen self-assigned this Oct 12, 2026
@coldtea-pr-lens
Copy link
Copy Markdown

Note

The title starts with test:, so PR Lens left this pull request undrawn. Comment @pr-lens draw to draw it

github.comment.notice: false in .github/pr-lens.yml turns this note off

@chatgpt-codex-connector
chatgpt-codex-connector Bot commented Oct 12, 2026 •
Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-12T17:30:35.402977Z 169763e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@oritwoen
oritwoen merged commit d99076c into main Oct 12, 2026
2 checks passed
@oritwoen
oritwoen deleted the test/drop-tautologies branch October 12, 2026 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0