8000 feat(tools): derive uncompressed wallets by aeitwoen · Pull Request #207 · agntn/keys · GitHub
[go: up one dir, main page]

Skip to content

feat(tools): derive uncompressed wallets - #207

Merged
oritwoen merged 1 commit into
mainfrom
feat/wallet-derive-compressed
Oct 1, 2026
Merged

oritwoen merged 1 commit into
mainfrom
feat/wallet-derive-compressed

Conversation

@aeitwoen
@aeitwoen aeitwoen commented Oct 1, 2026
Copy link
Copy Markdown
Collaborator

Closes #206

keys_wallet_derive always hashed the compressed key, so an old Bitcoin key took three calls to reach its real address. This adds compressed: false for that, and chains whose address ignores the flag refuse it rather than drop it.

@aeitwoen
aeitwoen requested a review from oritwoen as a code owner October 1, 2026 20:30
@aeitwoen aeitwoen self-assigned this Oct 1, 2026
@coldtea-pr-lens
coldtea-pr-lens Bot commented Oct 1, 2026 •
Copy link
Copy Markdown

◈ PR Lens

🟢 +0 new · 🟠 ~4 changed · 🔴 -0 removed · 1 flow · 5 files · commit 774c0cf


Architecture

Architecture diagram for agntn/keys at 774c0cf

4 components touched across 4 lanes.

Play the interactive walkthrough


Data flow

Data flow diagram for agntn/keys at 774c0cf

Deriving a wallet with public key compression

Follow each request, response and payload


View

  • Architecture lens
  • Data flow lens
  • Expand every detail

Tip

The diagrams are links. Click one to open it on the canvas, then press W or click play to walk through the change

🪧 More tips
  • Run npx skills add coldteadotai/pr-lens, then tell your coding agent: "Diagram the change you just made with PR Lens and attach it to the pull request."
  • Run npx @coldtea/pr-lens-cli analyze --base origin/main on a branch, then npx @coldtea/pr-lens-cli render .pr-lens/graph.json. Same lenses, your own model key, before the pull request exists
  • Untick Architecture lens or Data flow lens under View to hide a diagram, or tick Expand every detail to open every section. The comment redraws in a few seconds
  • Click the link under each diagram to open it on a canvas you can zoom, pan and step through
  • Open a diagram on the canvas, then press W or click play to walk through the change one step at a time
  • The CLI's render reads .github/pr-lens.yml and applies your renames, exclusions and lane pins at draw time
  • Set github.comment.collapsed: true in .github/pr-lens.yml to fold the comment behind one View architecture and data flow row. Drawing still runs as before
  • Set github.draw: on-demand in .github/pr-lens.yml and PR Lens stops drawing pull requests on its own. Comment @pr-lens draw on a pull request when you want that one drawn
  • Add .github/workflows/pr-lens.yml with coldteadotai/pr-lens/packages/action@v0 and your model provider's key as its api-key to run PR Lens from your own CI. Any /chat/completions endpoint works
  • Push a commit and the drawing stays, with a note that it is out of date. Tick Redraw in the note to draw the new head
  • Switch GitHub to dark mode and the diagrams follow. The moving dots are this pull request's data in motion

Thanks for using PR Lens! It's built by Coldtea, free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

@oritwoen
oritwoen merged commit f8ca5ae into main Oct 1, 2026
4 checks passed
@oritwoen
oritwoen deleted the feat/wallet-derive-compressed branch October 1, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Derive uncompressed addresses from a private key

2 participants

0