8000 feat(bip38): read a key without its passphrase by oritwoen · Pull Request #153 · agntn/keys · GitHub
[go: up one dir, main page]

Skip to content

feat(bip38): read a key without its passphrase - #153

Merged
oritwoen merged 3 commits into
mainfrom
feat/bip38-inspect
Sep 30, 2026
Merged

oritwoen merged 3 commits into
mainfrom
feat/bip38-inspect

Conversation

@oritwoen
@oritwoen oritwoen commented Sep 30, 2026 •
Copy link
Copy Markdown
Member

@agntn/keys/bip38 and the keys_bip38_inspect tool read a 6P... key without its passphrase, lot/sequence and address hash check included, which resolves #147. The landing and OG image count tools from TOOL_NAMES instead of a typed number.

@oritwoen oritwoen self-assigned this Sep 30, 2026
@coldtea-pr-lens
coldtea-pr-lens Bot commented Sep 30, 2026 •
Copy link
Copy Markdown

◈ PR Lens

Note

This drawing shows b33ac5f, and the branch has new commits since. Tick Redraw to draw the latest one

  • Redraw

🟢 +1 new · 🟠 ~11 changed · 🔴 -0 removed · 1 flow · 26 files · commit b33ac5f


Architecture

Architecture diagram for agntn/keys at b33ac5f

12 components touched across 6 lanes.

Play the interactive walkthrough


Inside the changed components — 2 views

Component view — Agent tool surfaces

Registration and dispatching of keys_inspect_bip38 across MCP stdio, remote HTTP MCP, Pi, and OMP extensions.

Architecture view of Component view — Agent tool surfaces in agntn/keys

Component view — BIP38 inspection & crypto

Core BIP38 header inspection module, public exports, schema validation, and SHA-256 address hashing.

Architecture view of Component view — BIP38 inspection & crypto in agntn/keys

Data flow

Data flow diagram for agntn/keys at b33ac5f

Inspecting a BIP38 encrypted key

Follow each request, response and payload


View

  • Architecture lens
  • Data flow lens
  • Expand every detail

Tip

Switch GitHub to dark mode and the diagrams follow. The moving dots are this pull request's data in motion

🪧 More tips
  • Run npx skills add coldteadotai/pr-lens, then tell your coding agent: "Diagram the change you just made with PR Lens and attach it to the pull request."
  • Run npx @coldtea/pr-lens-cli analyze --base origin/main on a branch, then npx @coldtea/pr-lens-cli render .pr-lens/graph.json. Same lenses, your own model key, before the pull request exists
  • Untick Architecture lens or Data flow lens under View to hide a diagram, or tick Expand every detail to open every section. The comment redraws in a few seconds
  • Click the link under each diagram to open it on a canvas you can zoom, pan and step through
  • The diagrams are links. Click one to open it on the canvas, then press W or click play to walk through the change
  • Open a diagram on the canvas, then press W or click play to walk through the change one step at a time
  • The CLI's render reads .github/pr-lens.yml and applies your renames, exclusions and lane pins at draw time
  • Set github.comment.collapsed: true in .github/pr-lens.yml to fold the comment behind one View architecture and data flow row. Drawing still runs as before
  • Set github.draw: on-demand in .github/pr-lens.yml and PR Lens stops drawing pull requests on its own. Comment @pr-lens draw on a pull request when you want that one drawn
  • Add .github/workflows/pr-lens.yml with coldteadotai/pr-lens/packages/action@v0 and your model provider's key as its api-key to run PR Lens from your own CI. Any /chat/completions endpoint works
  • Push a commit and the drawing stays, with a note that it is out of date. Tick Redraw in the note to draw the new head

Thanks for using PR Lens! It's built by Coldtea, free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

@chatgpt-codex-connector
chatgpt-codex-connector Bot commented Sep 30, 2026 •
Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-30T12:55:56.935410Z 4f78844 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cloudflare-workers-and-pages
cloudflare-workers-and-pages Bot commented Sep 30, 2026 •
Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview URL: https://feat-bip38-inspect-agntn-keys.oritwoen.workers.dev (commit 4f78844)

This URL reflects your latest Preview deployment

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://f83e561e-agntn-keys.oritwoen.workers.dev 4f78844 2026-09-30T12:54:39.554Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://d69b042d-agntn-keys.oritwoen.workers.dev ba964a4 2026-09-30T12:44:49.084Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://24f7ce5a-agntn-keys.oritwoen.workers.dev b33ac5f 2026-09-30T12:39:17.600Z Visit the dashboard ↗

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b33ac5f65b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/tool-operations.ts Resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: decode BIP38 encrypted key header without passphrase

1 participant

0