Repository navigation
feat: add support mldsa44 signatures for ldp VC - #291
Merged
Merged
Conversation
|
Coverage after merging dp-pqc into main will be
Coverage Report |
DenisPopov15
requested review from
ConstantineSynyshyn,
ivan-branets-affinidi and
oleksiipiliugin
June 23, 2026 08:57
There was a problem hiding this comment.
Pull request overview
Adds experimental ML-DSA-44 (FIPS 204) post-quantum signature support across the library, including PersistentWallet key management, Multikey/JWK interop, and W3C Data Integrity (JCS + RDFC) cryptosuites for issuing/verifying linked-data VCs.
Changes:
- Introduces
KeyType.mldsa44/SignatureScheme.mldsa44plus multikey indicator0x9024and AKP-style JWK encoding/decoding. - Adds ML-DSA-44 keypair implementation and integrates it into
PersistentWallet. - Adds Data Integrity proof generators/verifiers for
mldsa44-jcs-2024andmldsa44-rdfc-2024, plus end-to-end tests and an example.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| test/wallet/mldsa44_wallet_test.dart | Adds wallet-level tests for ML-DSA-44 key generation, persistence, signing, and unsupported ops. |
| test/key_pair/mldsa44_key_pair_test.dart | Adds unit tests for ML-DSA-44 keypair sizes, deterministic derivation, signing, and multikey encoding. |
| test/credentials/proof/data_integrity_mldsa_test.dart | Adds end-to-end issuance/verification tests for both ML-DSA Data Integrity cryptosuites. |
| lib/src/key_pair/mldsa44_key_pair.dart | Implements ML-DSA-44 keypair (generate/restore/fromSeed/sign/verify; no encryption/agreement). |
| lib/src/wallet/persistent_wallet.dart | Adds mldsa44 to wallet key generation and restore paths. |
| lib/src/types.dart | Adds new enum values and cryptosuite-to-scheme mappings for ML-DSA. |
| lib/src/did/public_key_utils.dart | Adds multikey↔JWK handling for ML-DSA-44 via AKP-style JWK and multicodec prefix 0x9024. |
| lib/src/did/did_manager/did_manager.dart | Defines supported verification relationships for ML-DSA-44 (signature-only; no keyAgreement). |
| lib/src/credentials/proof/data_integrity_mldsa_suite.dart | Adds ML-DSA Data Integrity generator/verifier implementations and a dedicated verification path. |
| lib/src/credentials/linked_data/ld_base_suite.dart | Wires cryptosuite dispatch so VC verification can select the new ML-DSA verifiers. |
| lib/src/credentials/proof/proof.dart | Exports the new ML-DSA Data Integrity suite. |
| lib/ssi.dart | Exposes MlDsa44KeyPair from the public package API. |
| pubspec.yaml | Bumps version to 3.10.0 and adds pqcrypto dependency. |
| example/code_snippets/credentials/vc/mldsa44_issue_verify.dart | Adds an end-to-end example for issuing/verifying a VC using ML-DSA-44 JCS cryptosuite. |
| README.md | Documents experimental ML-DSA-44 support, key facts, and points to the new example. |
| CHANGELOG.md | Records the feature release entry for v3.10.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
carlos-affinidi
previously approved these changes
Jun 23, 2026
DenisPopov15
changed the base branch from
feat/did-peer-strict-peer0-v2
to
v4-release
June 30, 2026 14:23
|
Coverage after merging dp-pqc into v4-release will be
Coverage Report |
|
Coverage after merging dp-pqc into v4-release will be
Coverage Report |
cosminm-affnd
approved these changes
Jul 22, 2026
marco-a-affinidi
approved these changes
Jul 22, 2026
carlos-affinidi
approved these changes
Jul 22, 2026
|
Coverage after merging dp-pqc into v4-release will be
Coverage Report |
DenisPopov15
added a commit
that referenced
this pull request
Jul 23, 2026
* feat: add support mldsa44 signatures for ldp VC * fix: add sec notice
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for the post quantum signatures mldsa44