8000 feat: revert JCS by soroush-y · Pull Request #177 · affinidi/affinidi-ssi-dart · GitHub
[go: up one dir, main page]
Skip to content
8000

feat: revert JCS - #177

Draft
soroush-y wants to merge 3 commits into
mainfrom
feat/undo-jcs
Draft

feat: revert JCS#177
soroush-y wants to merge 3 commits into
mainfrom
feat/undo-jcs

Conversation

@soroush-y
@soroush-y soroush-y commented Aug 1, 2025
Copy link
Copy Markdown
Contributor

No description provided.

@soroush-y
soroush-y requested a review from a team as a code owner August 1, 2025 09:06
@github-actions
github-actions Bot commented Aug 1, 2025
Copy link
Copy Markdown

Coverage after merging feat/undo-jcs into main will be

78.45%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src
   types.dart70.83%100%100%70.83%122, 159–160, 172, 174, 189, 244
   digest_utils.dart100%100%100%100%
   utility.dart100%100%100%100%
lib/src/credentials/jwt
   jwt_data_model_v1.dart97.56%100%100%97.56%57
   jwt_dm_v1_suite.dart86%100%100%86%109, 111, 36, 38, 56, 71, 73
lib/src/credentials/linked_data
   ld_base_suite.dart96.30%100%100%96.30%118, 120
   ld_dm_v1_suite.dart100%100%100%100%
   ld_dm_v2_suite.dart100%100%100%100%
lib/src/credentials/models/field_types
   issuer.dart100%100%100%100%
   credential_schema.dart100%100%100%100%
   credential_subject.dart72.97%100%100%72.97%38, 55, 57–58, 61, 64–65, 70–71, 94
   evidence.dart76.47%100%100%76.47%50–52, 54
   holder.dart92.31%100%100%92.31%90
   terms_of_use.dart75%100%100%75%46–48, 50
lib/src/credentials/models/field_types/credential_status
   revocation_list_2020.dart10.45%100%100%10.45%101–104, 107, 110–112, 114–116, 118–120, 122–124, 14, 170, 172, 174–181, 22–27, 48, 56–61, 65, 68–75, 81, 84–85, 87–88, 90–91, 93–94, 99
   v1.dart43.18%100%100%43.18%51–57, 60–61, 64, 66–68, 71, 73–76, 78, 82–83, 85–86, 88–89
   v2.dart63.64%100%100%63.64%59–60, 63, 65–67, 70, 72–75, 77, 81–82, 87–88
lib/src/credentials/models/field_types/refresh_service
   v1.dart76.47%100%100%76.47%46–48, 50
   v2.dart18.18%100%100%18.18%35–36, 38, 55–56, 61, 66–67, 69
lib/src/credentials/models/v1
   mutable_vc_data_model_v1.dart86.67%100%100%86.67%153, 155, 203–204, 210–211, 217, 223
   vc_data_model_v1.dart87.88%100%100%87.88%159–161, 166, 168–169, 174–176, 181–183
lib/src/credentials/models/v2
   mutable_vc_data_model_v2.dart43.33%100%100%43.33%145, 161–162, 164, 166, 168, 170, 172, 174–176, 179–180, 183, 185–187, 190, 192, 194, 196–198, 201, 203–205, 208, 210–211, 214, 216–217, 220
   vc_data_model_v2.dart86.96%100%100%86.96%138–140, 153–155, 160–162, 259, 265, 269
lib/src/credentials/parsers
   jwt_parser.dart88.89%100%100%88.89%51, 53
   ld_parser.dart85.71%100%100%85.71%26
   sdjwt_parser.dart70%100%100%70%40, 56, 58
lib/src/credentials/presentations/linked_data
   ld_vp_dm_v1_suite.dart100%100%100%100%
   ld_vp_dm_v2_suite.dart100%100%100%100%
lib/src/credentials/presentations/models
   vc_parse_present.dart88.89%100%100%88.89%27
lib/src/credentials/presentations/models/v1
   mutable_vp_data_model_v1.dart46.43%100%100%46.43%100–101, 104, 73, 76, 82–83, 85, 87–88, 90, 92, 94, 96–97
   vp_data_model_v1.dart82.69%100%100%82.69%79–81, 86, 88–89, 94–96
lib/src/credentials/presentations/models/v2
   vp_data_model_v2.dart82.76%100%100%82.76%100–101, 161, 84–86, 91, 93–94, 99
   mutable_vp_data_model_v2.dart45.45%100%100%45.45%100, 102–103, 106–107, 110, 112–113, 116, 78, 82, 88–89, 91, 93–94, 96, 98
lib/src/credentials/presentations/suites
   universal_presentation_parser.dart42.86%100%100%42.86%21–22, 24–25
   universal_presentation_verifier.dart0%100%100%0%30–34, 41, 44, 49–51, 53–56, 59–62, 65
   vp_suites.dart61.54%100%100%61.54%31, 33, 53–55
lib/src/credentials/presentations/verification
   delegation_vc_verifier.dart100%100%100%100%
   vp_expiry_verifier.dart100%100%100%100%
   vp_integrity_verifier.dart100%100%100%100%
   vp_domain_challenge_verifier.dart75%100%100%75%36, 53–54, 62–63
lib/src/credentials/proof
   data_integrity_ecdsa_suite.dart77.01%100%100%77.01%121, 129, 132, 135, 138, 141, 148, 151, 158, 288, 293, 322, 324, 342, 346, 348–349, 49, 51–52
   data_integrity_eddsa_suite.dart80.33%100%100%80.33%119, 127, 130, 133, 136, 139, 146, 149, 156, 47, 49–50
   ecdsa_secp256k1_signature2019_suite.dart98.33%100%100%98.33%110
   embedded_proof_suite.dart100%100%100%100%
   jcs_utils.dart51.02%100%100%51.02%17, 191, 194, 197, 212, 216, 220, 231–232, 240, 243, 42, 44–45, 53, 55, 61, 64, 72–73, 75, 79, 81, 84
   embedded_proof.dart70.59%100%100%70.59%107–108, 110, 114, 117, 148, 158–159, 165–167, 169, 183, 191, 197, 199, 76, 91, 96–97
   base_data_integrity_verifier.dart70.45%100%100%70.45%100, 125–126, 131–132, 138–139, 150, 152, 154–155, 158, 161–162, 166–167, 240, 242–243, 271, 276, 77–78, 84–85, 99
   base_jcs_generator.dart100%100%100%100%
   base_jcs_verifier.dart72.22%100%100%72.22%100–101, 112, 114–115, 150–151, 181–184, 186, 39, 48, 98
   base_secp256k1_verifier.dart83.78%100%100%83.78%113–114, 119–120, 129–130, 179, 181, 67–68, 74–75
lib/src/credentials/sdjwt
   enveloped_vc_suite.dart80%100%100%80%102–104, 113, 115–116, 67, 69,

@github-actions
github-actions Bot commented Aug 1, 2025
Copy link
Copy Markdown

Coverage after merging feat/undo-jcs into main will be

78.23%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src
   types.dart81.25%100%100%81.25%122, 145, 200
   utility.dart100%100%100%100%
   digest_utils.dart100%100%100%100%
lib/src/credentials/jwt
   jwt_data_model_v1.dart97.56%100%100%97.56%57
   jwt_dm_v1_suite.dart86%100%100%86%109, 111, 36, 38, 56, 71, 73
lib/src/credentials/linked_data
   ld_base_suite.dart96%100%100%96%117, 119
   ld_dm_v1_suite.dart100%100%100%100%
   ld_dm_v2_suite.dart100%100%100%100%
lib/src/credentials/models/field_types
   issuer.dart100%100%100%100%
   credential_schema.dart100%100%100%100%
   credential_subject.dart72.97%100%100%72.97%38, 55, 57–58, 61, 64–65, 70–71, 94
   evidence.dart76.47%100%100%76.47%50–52, 54
   holder.dart92.31%100%100%92.31%90
   terms_of_use.dart75%100%100%75%46–48, 50
lib/src/credentials/models/field_types/credential_status
   revocation_list_2020.dart10.45%100%100%10.45%101–104, 107, 110–112, 114–116, 118–120, 122–124, 14, 170, 172, 174–181, 22–27, 48, 56–61, 65, 68–75, 81, 84–85, 87–88, 90–91, 93–94, 99
   v1.dart43.18%100%100%43.18%51–57, 60–61, 64, 66–68, 71, 73–76, 78, 82–83, 85–86, 88–89
   v2.dart63.64%100%100%63.64%59–60, 63, 65–67, 70, 72–75, 77, 81–82, 87–88
lib/src/credentials/models/field_types/refresh_service
   v1.dart76.47%100%100%76.47%46–48, 50
   v2.dart18.18%100%100%18.18%35–36, 38, 55–56, 61, 66–67, 69
lib/src/credentials/models/v1
   mutable_vc_data_model_v1.dart86.67%100%100%86.67%153, 155, 203–204, 210–211, 217, 223
   vc_data_model_v1.dart87.88%100%100%87.88%159–161, 166, 168–169, 174–176, 181–183
lib/src/credentials/models/v2
   mutable_vc_data_model_v2.dart43.33%100%100%43.33%145, 161–162, 164, 166, 168, 170, 172, 174–176, 179–180, 183, 185–187, 190, 192, 194, 196–198, 201, 203–205, 208, 210–211, 214, 216–217, 220
   vc_data_model_v2.dart86.96%100%100%86.96%138–140, 153–155, 160–162, 259, 265, 269
lib/src/credentials/parsers
   jwt_parser.dart88.89%100%100%88.89%51, 53
   ld_parser.dart85.71%100%100%85.71%26
   sdjwt_parser.dart70%100%100%70%40, 56, 58
lib/src/credentials/presentations/linked_data
   ld_vp_dm_v1_suite.dart100%100%100%100%
   ld_vp_dm_v2_suite.dart100%100%100%100%
lib/src/credentials/presentations/models
   vc_parse_present.dart88.89%100%100%88.89%27
lib/src/credentials/presentations/models/v1
   mutable_vp_data_model_v1.dart46.43%100%100%46.43%100–101, 104, 73, 76, 82–83, 85, 87–88, 90, 92, 94, 96–97
   vp_data_model_v1.dart82.69%100%100%82.69%79–81, 86, 88–89, 94–96
lib/src/credentials/presentations/models/v2
   vp_data_model_v2.dart82.76%100%100%82.76%100–101, 161, 84–86, 91, 93–94, 99
   mutable_vp_data_model_v2.dart45.45%100%100%45.45%100, 102–103, 106–107, 110, 112–113, 116, 78, 82, 88–89, 91, 93–94, 96, 98
lib/src/credentials/presentations/suites
   universal_present 10BC8 ation_parser.dart42.86%100%100%42.86%21–22, 24–25
   universal_presentation_verifier.dart0%100%100%0%30–34, 41, 44, 49–51, 53–56, 59–62, 65
   vp_suites.dart61.54%100%100%61.54%31, 33, 53–55
lib/src/credentials/presentations/verification
   delegation_vc_verifier.dart100%100%100%100%
   vp_expiry_verifier.dart100%100%100%100%
   vp_integrity_verifier.dart100%100%100%100%
   vp_domain_challenge_verifier.dart75%100%100%75%36, 53–54, 62–63
lib/src/credentials/proof
   data_integrity_ecdsa_suite.dart92.50%100%100%92.50%43, 45–46
   data_integrity_eddsa_suite.dart92.50%100%100%92.50%43, 45–46
   ecdsa_secp256k1_signature2019_suite.dart98.33%100%100%98.33%110
   embedded_proof_suite.dart100%100%100%100%
   embedded_proof.dart70.59%100%100%70.59%107–108, 110, 114, 117, 148, 158–159, 165–167, 169, 183, 191, 197, 199, 76, 91, 96–97
   base_data_integrity_verifier.dart67.09%100%100%67.09%116–117, 122–123, 129–130, 141, 143, 145–146, 149, 152–153, 157–158, 209, 211–212, 236, 241, 70–71, 77–78, 90–91
   base_secp256k1_verifier.dart83.78%100%100%83.78%113–114, 119–120, 129–130, 179, 181, 67–68, 74–75
lib/src/credentials/sdjwt
   enveloped_vc_suite.dart80%100%100%80%102–104, 113, 115–116, 67, 69, 99
   sdjwt_dm_v2_suite.dart82.35%100%100%82.35%110, 112, 133–137, 192, 262, 265, 58, 60
   sdjwt_did_verifier.dart100%100%100%100%
lib/src/credentials/suites
   vc_suites.dart81.25%100%100%81.25%54–56
   universal_parser.dart100%100%100%100%
   universal_verifier.dart100%100%100%100%
lib/src/credentials/verification
   vc_expiry_verifier.dart100%100%100%100%
   vc_integrity_verifier.dart100%100%100%100%
   vc_revocation_verifier.dart80.70%100%100%80.70%140–142, 144, 146, 149, 37–38, 41, 44, 82
lib/src/did
   did_signer.dart50%100%100%50%61, 63, 68, 70, 75, 77, 82–86
   did_verifier.dart77.55%100%100%77.55%106–107, 112–113, 115–116, 135, 51, 62, 64–65
   public_key_utils.dart56.38%100%100%56.38%100–109, 111–113, 126–127, 130–132, 134–136, 138–140, 142–143, 146–147, 149–150, 153–154, 156–157, 160–161, 163–164, 168–170,

@soroush-y
soroush-y marked this pull request as draft August 1, 2025 11:21

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ConstantineSynyshyn ConstantineSynyshyn ConstantineSynyshyn approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@soroush-y @ConstantineSynyshyn
0