Repository navigation
Conversation
soroush-y
marked this pull request as ready for review
June 11, 2025 13:49
cosminm-affnd
approved these changes
Jun 11, 2025
sureshaff
reviewed
Jun 12, 2025
|
|
||
| // Validate proofPurpose is present to prevent misuse | ||
| // See: https://www.w3.org/TR/vc-data-integrity/#proofs | ||
| if (proof['proofPurpose'] == null) { |
There was a problem hiding this comment.
please follow the algorithm defined here for the validation -> https://www.w3.org/TR/vc-data-integrity/#verify-proof
If expectedProofPurpose was given, and it does not match proof.proofPurpose, an error MUST be raised and SHOULD convey an error type of [PROOF_VERIFICATION_ERROR](https://www.w3.org/TR/vc-data-integrity/#PROOF_VERIFICATION_ERROR).
|
@soroush-y , should we also do the same changes to the https://github.com/affinidi/affinidi-ssi-dart/blob/main/lib/src/credentials/proof/base_secp256k1_verifier.dart as well ? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.