Repository navigation
fix(desktop): check the update's signature against the repository's key at build time - #354
Merged
Merged
Conversation
…ey at build time tauri build verifies the updater signature against the config's pubkey, which is empty in tauri.conf.json, so a build with the update key failed with "Missing comment in public key". The Desktop workflow now passes LENS_UPDATER_PUBKEY in the build config too. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014VrJQhkYVDyhgVQcok4neG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Adeel · project thread
Before: once the update key was set, the Desktop build failed at the end with "failed to decode pubkey: Missing comment in public key" (run).
After: the build signs
Lens.app.tar.gz, checks the signature against the repository's key and writeslatest.json.How:
tauri buildchecks the updater signature againstplugins.updater.pubkeyfrom the config, and that is empty intauri.conf.json. The workflow now passesLENS_UPDATER_PUBKEYthere too, in the same--configthat turns oncreateUpdaterArtifacts.🤖 Generated with Claude Code
https://claude.ai/code/session_014VrJQhkYVDyhgVQcok4neG
Generated by Claude Code