Repository navigation
fix(ui): open the graph on the namespace that has one - #339
Merged
Merged
Conversation
With no namespace picked, the graph opened on all shared namespaces even when only a namespace that keeps its graph to itself had anything, so it showed empty until that namespace was picked in the switcher. It now opens there, waits for the namespaces before building a graph, and on a computer the Find in graph box has the focus. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018GNzYTT6fQRMPesPRNan3u
18 of 22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Adeel · project thread
Description
Before: on a fresh install (podcasts shared, interviews isolated), Graph opened on "all shared namespaces" while everything imported sat in interviews, which keeps its graph to itself. The page said "No graph for all shared namespaces yet" until interviews was picked in the namespace switcher. On a phone that couldn't be done at all, because the switcher is hidden below 640px.
After: with no namespace picked, Graph opens on all shared namespaces as before when any of them has a graph. When none does and an isolated namespace has one, it opens on that namespace (the fullest if there are several). On a computer the Find in graph box has the focus, so typing a name and pressing Enter finds it. A namespace in the URL, one picked in the top bar, or "All shared" in the filters is always kept.
Clicks survey (
ci/clicks/run.shfrom #325, journey graph-find "Find a speaker in the graph of what was imported", same machine before and after, only this journey changed):Motivation and Context
Adeel asked to cut clicks, keys and touches. The survey's top item for the graph: "The first namespace keeps its graph to itself, so the graph opens empty until it is picked in the switcher."
How
openingNamespace()incomponents/graph/model.tspicks where the graph opens from the namespace list the app already loads (analyzed recordings + speakers per namespace). It makes no new API call.graph-page.tsxuses it only when nothing is picked, and waits for the namespaces before building a graph, so it doesn't build the empty global one first.autoFocus. The phone's filters sheet is left as it is.Types of changes
!in the title)Checklist:
__tests__/graph-opening.test.ts.docs/accordingly (docs/graph.md, The explorer).## UnreleasedinCHANGELOG.md. n/a, the title says it.Done questions (AGENTS.md)
baseline.jsonhas no graph journey yet. The graph-find journey andbaseline-phone.jsonarrive with ci(clicks): survey every module, and on a phone with taps and swipes #325, which re-baselines from main, so it records these counts.🤖 Generated with Claude Code
https://claude.ai/code/session_018GNzYTT6fQRMPesPRNan3u