Repository navigation
ci: test and build the web clipper through Nx - #313
Merged
Merged
Conversation
extensions/browser gets a project.json (Nx project `clipper`): `install` runs `npm ci` when the lockfile is newer than node_modules, and `test` and `build` (every browser target, with the manifest check) depend on it. CI's Other projects job now runs them whenever a change affects the clipper; the browser workflows keep building and keeping the zips as before. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018t1esJmuFFT1yrtmWSPHqz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Adeel · project thread
Description
Before: the web clipper (
extensions/browser) was invisible to Nx, somake affectedand CI's Other projects job skipped it.After: it is the Nx project
clipper.pnpm exec nx run-many -t test build -p clipperinstalls (only when the lockfile changed), runs its tests and builds every browser target with the manifest check, and CI's Other projects runs the same whenever a change affects it. The Browser extension, Edge and Safari workflows are unchanged and still keep the zips with each run.Motivation and Context
Follow-up to #303: fold each project into Nx as it lands on main.
How
extensions/browser/project.json:installrunsnpm ci --include=devunlessnode_modules/.package-lock.jsonis newer thanpackage-lock.json;test(npm test) andbuild(npm run check, outputsdist/,EXT_VERSIONas an input) depend on it. Locally: 22 tests pass, chrome/edge/safari build; a second run skips the install and replays from the cache.nx show projects --affectedfor this branch: docs, clipper.docs/contributing.mdanddocs/web-clipper.mdsay how to run it.Types of changes
!in the title)Checklist:
make hookschecks it on commit).docs/accordingly.## UnreleasedinCHANGELOG.md. (n/a: contributor tooling.)Done questions (AGENTS.md)
Refine later
project.jsononce it merges.🤖 Generated with Claude Code
https://claude.ai/code/session_018t1esJmuFFT1yrtmWSPHqz
Generated by Claude Code