Repository navigation
feat(clipper): Edge build, Edge Add-ons package and Edge smoke test - #285
Merged
Merged
Conversation
A MV3 extension in extensions/browser: clip the page (Readability), the selection or a picked element to Markdown with MarkDownload-style templates, and send it to Lens through a namespace's import webhook. Shared core for the Firefox, Edge and Safari targets; CI builds a zip per target and attaches them to releases. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018uA6PhZXrmpgsbfDh2W23u
…t in CI Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JdVNcZL5BUSx3iwStCtq3U
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Adeel · project thread
Before: the web clipper (#277) built only for Chrome, and nothing checked it in Edge.
After: every run and release also produces
lens-clipper-edge.zip, which you can load unpacked in Edge or upload to Edge Add-ons as it is. CI loads that build into real Microsoft Edge and clips a page into a stand-in Lens.How:
extensions/browser/targets/edge.jsonis the Edge manifest overlay, which the existing Browser extension workflow builds and zips with the other targets. Store publishing stays in that workflow (#294).extensions/browser/edge/smoke.mjs(Playwright core,msedgechannel, under xvfb) checks the options page and popup render, then clips an article and checks the result: front matter title and author, list and code block, footer dropped, and the push carries the hook token and the Markdown..github/workflows/clipper-edge.ymlruns it and installs Edge if the runner lacks it. I ran it locally against Edge 155 and Chromium, and all checks pass.🤖 Generated with Claude Code
https://claude.ai/code/session_01JdVNcZL5BUSx3iwStCtq3U