Repository navigation
fix(install): pull the microsandbox base image from mirrors that need no sign-in - #259
Merged
Merged
Conversation
… no sign-in On a Mac, msb's pull of python:3.12-slim-bookworm from Docker Hub failed with "Not authorized". install.sh now pulls it from mirror.gcr.io, then public.ecr.aws, then Docker Hub, and starts the sandbox from whichever answered. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VvAGWoQxiwkGkk374pvkSh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Adeel · project thread
Description
Before: on a Mac with Apple silicon, choosing microsandbox in the installer stopped with
error: image error: registry error: Not authorized: url https://index.docker.io/v2/library/python/manifests/3.12-slim-bookworm.After: install.sh pulls the base image itself before starting the sandbox. It tries
mirror.gcr.io, Google's Docker Hub mirror, which needs no sign-in. If that fails it triespublic.ecr.aws/docker/library, then Docker Hub itself. The sandbox starts from whichever one answers. If all three fail, the installer shows the last error.Motivation and Context
This came from Adeel's own install on macOS arm64 with msb v0.7.8. Docker Hub can refuse the pull when the machine has Docker Hub credentials that microsandbox can't use, and it also limits anonymous pulls.
Steps to reproduce (if appropriate):
msb pull mirror.gcr.io/library/python:3.12-slim-bookwormworked with msb 0.7.8. The mirror serves both arm64 and amd64. The microsandbox CI job runs the whole install through the new pull.Types of changes
!in the title)Checklist:
make hookschecks it on commit).docs/accordingly.## UnreleasedinCHANGELOG.md.🤖 Generated with Claude Code
https://claude.ai/code/session_01VvAGWoQxiwkGkk374pvkSh
Generated by Claude Code