Repository navigation
feat(install): list the prerequisites and ask before installing them - #258
Merged
Merged
Conversation
At a terminal, install.sh now says what it will install (Docker or OrbStack, Homebrew, microsandbox, the KVM module and access, the Compose plugin) and asks once; without a terminal, or with LENS_YES=1, it goes ahead as before. It also installs Homebrew on a Mac that has none, loads the KVM module when /dev/kvm is missing, and installs a missing Compose plugin with apt or dnf. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VvAGWoQxiwkGkk374pvkSh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Adeel · project thread
Description
Before: install.sh installed Docker, OrbStack or microsandbox on its own, without saying so first. On a Mac without Homebrew it stopped and told you to install Docker yourself. When the KVM module wasn't loaded, microsandbox wasn't offered at all.
After: at a terminal, it first lists what it's about to install and asks once:
Answering no installs nothing. With no terminal (CI, scripts) or with
LENS_YES=1, it goes ahead as it did before.It also installs more of what it needs by itself:
modprobe, when the CPU supports virtualization but/dev/kvmis missing.Motivation and Context
Adeel asked whether the installer installs dependencies itself, asking and confirming in the terminal. The project's principle is that Lens installs its own prerequisites.
Steps to reproduce (if appropriate):
I tested this in a Debian container without Docker. The installer listed Docker, and answering
nstopped it with "Nothing was installed". The install workflow's jobs (Docker and microsandbox) cover the no-terminal path.Types of changes
!in the title)Checklist:
make hookschecks it on commit).docs/accordingly.## UnreleasedinCHANGELOG.md.🤖 Generated with Claude Code
https://claude.ai/code/session_01VvAGWoQxiwkGkk374pvkSh
Generated by Claude Code