Repository navigation
fix(docker): publish the dev sensor ports on this machine only - #204
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W42z4FbekWr33b6791svQQ
3 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Adeel · project thread
Description
Before: the development compose file published the sensor hub's MQTT (1883) and syslog (5514) ports on every network interface, so anyone on the same network as a developer's laptop could reach them.
After:
docker-compose.ymlpublishes them on 127.0.0.1 only.LENS_SENSOR_BIND=0.0.0.0opens them to the network again for testing real devices. The production compose file is unchanged, so existing installs and their LAN sensors keep working.Motivation and Context
This answers threat-model question Q36 for development. Changing the production file is held, because sensors on the network would stop connecting.
Steps to reproduce (if appropriate):
docker compose configshows the ports bound to 127.0.0.1.Types of changes
!in the title)Checklist:
make hookschecks it on commit).docs/accordingly.## UnreleasedinCHANGELOG.md.🤖 Generated with Claude Code
https://claude.ai/code/session_01W42z4FbekWr33b6791svQQ
Generated by Claude Code