Repository navigation
fix(mcp): cap the page offset of list_recordings, list_entities and list_topics - #200
Merged
Merged
Conversation
…ist_topics search and get_entity already stop at 10,000; the three list tools took any offset, so a huge one could reach the database as a long scan or an error. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W42z4FbekWr33b6791svQQ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Adeel · project thread
Description
Before: the MCP tools
searchandget_entitycapped their offsets at 10,000, butlist_recordings,list_entitiesandlist_topicsaccepted any offset. A huge value went straight to the database as a long scan or an error.After: those three refuse an offset above 10,000 with the usual "offset ..." tool error, the same as
search. Agents paging normally see no difference.Motivation and Context
This answers threat-model question Q47: MCP tool arguments share the search maximums, and an argument past them is refused (P-RETRIEVAL).
Steps to reproduce (if appropriate):
The new loop in
tests/api/test_mcp.pyfails on main and passes here.Types of changes
!in the title)Checklist:
make hookschecks it on commit).docs/accordingly.## UnreleasedinCHANGELOG.md.🤖 Generated with Claude Code
https://claude.ai/code/session_01W42z4FbekWr33b6791svQQ
Generated by Claude Code