Repository navigation
fix(search): satisfy mypy on the text index sync at startup - #178
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016Z1gJcSd2Kp39i5j5KZivi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Adeel · project thread
Before: main fails the backend CI job's type check (
app/core/runtime.py:52: Item "None" of "Any | None" has no attribute "sync"), added in #166 while the runner was down, so the backend tests never run.After: the type check passes and the startup text-index sync returns early when there is no SQLite index (the caller already only starts it when one exists, so behaviour is unchanged).
How: read
self.db.textindexinto a local and bail out when it isNonebefore callingsync().Local CI (
ci/local-ci.sh, a faithful replay of ci.yml) on this head: FastAPI (embedded SurrealDB) passes, lint, mypy, OpenAPI drift and all tests, in 471 s.🤖 Generated with Claude Code
https://claude.ai/code/session_016Z1gJcSd2Kp39i5j5KZivi
Generated by Claude Code