8000 feat(storage): choose where files go in Settings → Storage and the setup wizard by adeelahmad · Pull Request #149 · adeelahmad/lense · GitHub
[go: up one dir, main page]
Skip to content

feat(storage): choose where files go in Settings → Storage and the setup wizard - #149

Merged
adeelahmad merged 1 commit into
mainfrom
claude/notes-module-j9j30y
Oct 5, 2026
Merged

feat(storage): choose where files go in Settings → Storage and the setup wizard#149
adeelahmad merged 1 commit into
mainfrom
claude/notes-module-j9j30y

Conversation

@adeelahmad
@adeelahmad adeelahmad commented Oct 5, 2026
Copy link
Copy Markdown
Owner

Before: the file store from #148 could only be configured through the API or the assistant.

After:

  • Settings → Storage has a "Keep files" choice: on this machine, or on a storage connection. For a connection you pick it from a list, set a folder, and optionally turn on "Also encrypt with rclone crypt". A banner shows where files currently go.
  • Check it writes a small file to the chosen place, reads it back and removes it. It tries the unsaved choices too.
  • Add a connection opens the same dialog as Sources (type → details → test and name), and the new connection is selected straight away.
  • The setup wizard's Storage step asks the same question. A chosen connection is checked before it's saved, and the step won't save one that doesn't work.

Email and calendar connections are never offered as storage.

How:

  • A new storage settings section with fields for files.*.
  • StorageBody in components/settings/bodies.tsx.
  • Shared helpers in components/storage/ (AddConnection and fileStoreTry).
  • Validation that mirrors the backend: a connection is required when storing on one, and a folder can't contain ...
  • The wizard saves through the existing Admin.updateSettings and Admin.testFileStore.
  • tsc, eslint and prettier pass. The settings, wizard and new file-store jest tests pass (31).

🤖 Generated with Claude Code

https://claude.ai/code/session_01XZQXJtCvJgbG1Z2H312KcS

Generated by Claude Code

@claude
feat(storage): choose where files go in Settings → Storage and the se…
8ea1b7c 
…tup wizard

Settings → Storage picks this machine or a storage connection, its folder and
rclone crypt, with a check that writes, reads back and removes a small file. A
connection can be added right there with the Sources dialog. The setup wizard's
Storage step asks the same and checks the connection before saving it.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XZQXJtCvJgbG1Z2H312KcS
@adeelahmad
adeelahmad merged commit fae564d into main Oct 5, 2026
0 of 5 checks passed
@adeelahmad adeelahmad mentioned this pull request Oct 5, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adeelahmad @claude
0