8000 fix(graph): let the graph explorer and canvas zoom in further by adeelahmad · Pull Request #144 · adeelahmad/lense · GitHub
[go: up one dir, main page]

Skip to content

fix(graph): let the graph explorer and canvas zoom in further - #144

Merged
adeelahmad merged 4 commits into
mainfrom
claude/project-thread-ak0hb4
Oct 5, 2026
Merged

adeelahmad merged 4 commits into
mainfrom
claude/project-thread-ak0hb4

Conversation

@adeelahmad
Copy link
Copy Markdown
Owner

Requested by Adeel · project thread

Description

Before: zooming in on the Graph page stopped at 8x the fitted view, so a dense cluster of nodes stayed packed together. The workflow canvas stopped at React Flow's default 2x.

After: the graph explorer zooms in to 100x the fitted view. Nodes and labels keep their on-screen size, so zooming in spreads a dense cluster apart. The workflow canvas zooms in to 8x. Zoom out limits, fit and reset are unchanged.

How: the graph canvas's two hard-coded 8 caps (wheel/buttons/keys and pinch) now share MIN_ZOOM/MAX_ZOOM constants; flow-canvas.tsx sets maxZoom={8} on <ReactFlow> (fit-to-view still caps at 1x).

Motivation and Context

Reported in the project thread: "why can't I keep zooming in?"

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change; ! in the title)

Checklist:

  • The title is a Conventional Commit.
  • My code follows the code style of this project (make hooks checks it on commit).
  • I added or updated tests.
  • My change requires documentation updates, and I have updated docs/ accordingly.
  • Users need more than the title to understand it, so I wrote it under ## Unreleased in CHANGELOG.md.

Checked locally: tsc --noEmit, eslint and prettier on both files, and the graph/canvas jest tests pass.

🤖 Generated with Claude Code

https://claude.ai/code/session_01DdhQ2PsqzCyrKNDV1SJZAA


Generated by Claude Code

The graph explorer capped zoom at 8x the fitted view, so dense clusters
stayed packed together. Raise the cap to 100x (nodes keep their on-screen
size, so zooming spreads them out). The workflow canvas used React Flow's
default 2x cap; raise it to 8x.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DdhQ2PsqzCyrKNDV1SJZAA
@adeelahmad adeelahmad self-assigned this Oct 4, 2026
claude added 2 commits October 4, 2026 15:50
… the slow collections test

The embedded suite took 28 min of its 30 on the runner at 544 tests, and
the server suite timed out at 30 with a third left; both now report their
slowest tests. The collections dialog test ran five flows in one test and
took 36 s against Jest's 20 s; each flow is its own test now.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GSZ2xxfNPjTPbhi8YqoPGm
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DdhQ2PsqzCyrKNDV1SJZAA
adeelahmad commented Oct 4, 2026 •
edited
Loading
Copy link
Copy Markdown
Owner Author

FastAPI (SurrealDB server) failed on 117b354 after about 24 minutes, with no logs available (404). This PR changes only two frontend files, so the backend suite can't be failing because of it. The run time matches the 30-minute test timeout that #145 raises on the self-hosted runner. I merged #145's branch into this one (57feaa9), so this PR picks up that fix, and the merge does nothing once #145 lands on main. The full frontend jest suite passes locally (686 tests).

Update (57feaa9): the same job hit #145's new 75-minute limit with 56% of its 637 tests run and no failures (log). The backend suite against the SurrealDB server is too slow for the runner even with #145's limit. This is still not caused by this PR, and no fix exists yet. I'm not re-running the job, since a re-run would hit the same limit.


Generated by Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DdhQ2PsqzCyrKNDV1SJZAA
@adeelahmad
adeelahmad merged commit d204ea7 into main Oct 5, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0