8000 fix(notes): narrow read_note's draft page so mypy passes by adeelahmad · Pull Request #143 · adeelahmad/lense · GitHub
[go: up one dir, main page]
Skip to content

fix(notes): narrow read_note's draft page so mypy passes #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adeelahmad merged 1 commit into from
Oct 4, 2026
Merged

fix(notes): narrow read_note's draft page so mypy passes #143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions fastapi_backend/app/api/mcp_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
from app.domain import topics as topicmod
from app.domain.store import DB
from app.schemas.entities import EntityList
from app.schemas.notebook import NotePage
from app.schemas.search import SearchResults

R = store.R
Expand Down Expand Up @@ -1207,9 +1208,10 @@ def read_note(ctx: Context, note_id: int | None, about: str | None) -> dict[str,
kind, _, key = str(about).partition(":")
if not key.isdigit():
raise ToolError('about is a thing like "recording:12"')
p = note_routes.page_about(kind, int(key), ctx.user, ctx.acl, ctx.db)
if p.id is None:
return {"page_of": about, "note": None, "title": p.title, "linked_from": [b.title for b in p.backlinks] or None}
page = note_routes.page_about(kind, int(key), ctx.user, ctx.acl, ctx.db)
if not isinstance(page, NotePage): # a draft: nobody has written on it yet
return {"page_of": about, "note": None, "title": page.title, "linked_from": [b.title for b in page.backlinks] or None}
p = page
return store.clean(
{
"note_id": p.id,
Expand Down
Loading
0