8000 feat(notes): suggest links to the topics and named things a note mentions by adeelahmad · Pull Request #140 · adeelahmad/lense · GitHub
[go: up one dir, main page]

Skip to content

feat(notes): suggest links to the topics and named things a note mentions - #140

Merged
adeelahmad merged 1 commit into
mainfrom
claude/notes-module-j9j30y
Oct 4, 2026
Merged

adeelahmad merged 1 commit into
mainfrom
claude/notes-module-j9j30y

Conversation

@adeelahmad
Copy link
Copy Markdown
Owner

Description

Before: a note that mentioned "Ada Lovelace" or "capsids" in plain text wasn't connected to that person or topic unless someone typed an @ or # link.

After: under the editor, a note suggests links to what it names but doesn't link yet: the namespace's topics, matched by any of their labels, and its people, organisations, places and other named things, matched by name or alias. One click adds the link and the note joins the graph. The assistant sees the same list as could_link when it reads a note, so it can link its own notes.

Motivation and Context

Notes module: "self-organised by the AI ... ontology-based organisation". No model is asked: the matcher compares the namespace's own vocabulary with the note's words, using topics._vocab and analyze.ent_key. Dates and numbers are never suggested. A single word only matches when it's written with a capital, which keeps common words out. New route: GET /api/v1/notes/{id}/suggestions.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change; ! in the title)

Checklist:

  • The title is a Conventional Commit.
  • My code follows the code style of this project (make hooks checks it on commit).
  • I added or updated tests.
  • My change requires documentation updates, and I have updated docs/ accordingly.
  • Users need more than the title to understand it, so I wrote it under ## Unreleased in CHANGELOG.md.

Checked locally: notes tests pass, along with ruff, tsc and eslint. The OpenAPI client was regenerated. The full backend suite is running.

🤖 Generated with Claude Code

https://claude.ai/code/session_01XZQXJtCvJgbG1Z2H312KcS


Generated by Claude Code

…ions

A note lists what its text names but doesn't link yet: the namespace's
topics by any label, and its people, organisations and other named
things by name or alias. One click adds the link. The assistant sees the
same list as could_link when it reads a note. No model is asked.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XZQXJtCvJgbG1Z2H312KcS
Copy link
Copy Markdown
Owner Author

The FastAPI (SurrealDB server) failure is from an old commit (0e16c0b), not this PR's head (a0da49a). The step hit its 30-minute limit on the slow self-hosted runner after 66% of the tests, and every test that ran passed (. and s only, no failures). That's the runner timing out, not a test failing. I can't re-run it from here. The full backend suite is running locally on the current head, and this merges on that result under the repo's merge policy.


Generated by Claude Code

@adeelahmad
adeelahmad merged commit b468469 into main Oct 4, 2026
0 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0