Repository navigation
perf(activity): write request rows off the event loop - #132
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AMq5CNuWmtn3Suj1EamYBT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: the activity middleware wrote its ledger row on the event loop after every changing request. While that write ran, other requests waited.
After: the row is written in a worker thread. Other requests carry on while it is written, and the row still exists by the time the request finishes, so tests and history reads see it at once.
How:
activity.Middlewarenow runs_logwithasyncio.to_thread. That copies the request's context, so the resources the request attributed are kept.Full backend suite (embedded engine): 593 passed. The only failures were the two known environmental tests (conversion, voice).
🤖 Generated with Claude Code
https://claude.ai/code/session_01AMq5CNuWmtn3Suj1EamYBT
Generated by Claude Code