Repository navigation
feat(faces): name a namespace's unnamed faces in a row - #694
Merged
Merged
Conversation
List the faces nobody has named yet, largest group first, with a few
crops, the assets each is in and a name to offer (GET
/namespaces/{name}/faces/unnamed, MCP list_unnamed_faces). Naming one
(POST /faces/{fid}/name, MCP name_face) reuses rename, or merge when
another face already has that name, so it joins that person; both undo.
Settings -> People gets an Unnamed faces tab where faces are recognised:
the first name field has focus, Enter names it and moves to the next,
with Undo; a video's People tab links to it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QFUNzy1QZy5HhKAyJxTAYJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Adeel · project thread
Description
Before: faces found in videos could only be named one at a time from each video's People tab, so a namespace with many unnamed faces took many trips.
After: Settings → People has an Unnamed faces tab listing every face nobody has named yet, largest group first, with a few crops, the assets each appears in and a suggested name. The first name field has focus; Enter names the face and moves to the next, with Undo. A video's People tab links there. Agents get the same through
GET /namespaces/{name}/faces/unnamed/ MCPlist_unnamed_facesandPOST /faces/{fid}/name/ MCPname_face.Naming reuses rename, or merge when another face already carries that name, so the face joins that person; both undo.
Motivation and Context
Personal feature plan: name people across a library quickly.
Types of changes
!in the title)Checklist:
make hookschecks it on commit).docs/accordingly.changelog.d/unnamed-faces.md, per build(release): changelog fragments in changelog.d/ instead of one Unreleased section #581.Done questions (AGENTS.md)
list_unnamed_faces,name_face)..envedit or manual step.make openapi).Local CI:
pytest tests/api/test_unnamed_faces.py tests/api/test_mcp.py(23 passed), ruff, mypy, jestname-faces.test.tsx(3 passed),tsc --noEmit,ci/check_requirements.pyall clean; OpenAPI regenerated with no drift.Generated by Claude Code