Repository navigation
feat(search): find and filter moments by sound events like laughter or applause - #670
Merged
Merged
Conversation
…r applause Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QFUNzy1QZy5HhKAyJxTAYJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Adeel · project thread
Description
Before: the sounds a speech provider hears (laughter, applause, music) were stored on segments but search couldn't find or filter by them.
After: sound is a search filter like emotion. Type
event:laughter(any case;musicis the BGM tag), pick one under Sounds in the filters, or passeventtoGET /api/v1/search, a saved search or the MCPsearchtool. Each hit says its sound, and the facets count them (events), leaving plain speech out.How:
domain/search.pyfilters and counts on the segments' event tag, normalised bystore.norm_event; the query parser and facet panel learnevent:.Motivation and Context
Item from the personal feature plan sheet ("find the funny bits").
Screenshots (if appropriate):
n/a
Steps to reproduce (if appropriate):
Search
event:laughteron an archive transcribed by a provider that tags sounds.Types of changes
!in the title)Checklist:
make hookschecks it on commit).tests/api/test_search.py,tests/api/test_semantic.py,__tests__/search.test.ts).docs/accordingly (docs/api.md,docs/processing.md,docs/mcp.md).## UnreleasedinCHANGELOG.md. Written aschangelog.d/sound-events.md, per build(release): changelog fragments in changelog.d/ instead of one Unreleased section #581.Done questions (AGENTS.md)
eventonGET /api/v1/searchand the MCPsearchtool..envedit or manual step.event:in the box.make openapi).Local CI (
ci/local-ci.sh): FastAPI (embedded and server), Next.js (1268 tests), pre-commit and PR title passed.Generated by Claude Code