Repository navigation
feat(speakers): split one asset's voice off the person it was matched to - #663
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QFUNzy1QZy5HhKAyJxTAYJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden
6D13
Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Adeel · project thread
Description
Before: when voice recognition matched someone to the wrong person in one recording, the only fixes were renaming the person everywhere or splitting by hand.
After: on that person's card in the asset's Speakers tab, Not them here gives their lines in that asset to a new person, works out the first person's voice again from the assets they're still in, and marks the two as not the same so they aren't suggested again. Undo merges them back. Agents use
POST /api/v1/speakers/{sid}/detach {recording}.How:
speakers.detachmoves the asset's segments and appearance to a new speaker, recomputes the original's voiceprint and records a not-same pair; it is audited asspeaker.detach.Motivation and Context
Item from the personal feature plan sheet ("wrong person matched in one recording").
Screenshots (if appropriate):
n/a
Steps to reproduce (if appropriate):
Open an asset › Speakers › a person's card › Not them here; press Undo on the toast.
Types of changes
!in the title)Checklist:
make hookschecks it on commit).tests/api/test_speakers.py).docs/accordingly (docs/api.md,docs/processing.md).## UnreleasedinCHANGELOG.md. Written aschangelog.d/detach-voice.md, per build(release): changelog fragments in changelog.d/ instead of one Unreleased section #581.Done questions (AGENTS.md)
POST /api/v1/speakers/{sid}/detach..envedit or manual step.make openapi).Local CI (
ci/local-ci.sh): FastAPI (embedded and server), Next.js, pre-commit and PR title passed.Generated by Claude Code