8000 feat(circles): rules that share with a circle, asking first until let by adeelahmad · Pull Request #653 · adeelahmad/lense · GitHub
[go: up one dir, main page]

Skip to content

feat(circles): rules that share with a circle, asking first until let - #653

Merged
adeelahmad merged 4 commits into
mainfrom
claude/project-thread-97gkhw
Oct 19, 2026
Merged

adeelahmad merged 4 commits into
mainfrom
claude/project-thread-97gkhw

Conversation

@adeelahmad
Copy link
Copy Markdown
Owner

Requested by Adeel · project thread

Description

Before: sharing with a circle was always a person's click or an assistant proposal they approved.

After: a share_with_circle automation action shares what comes in (the school's emails, a calendar's events, a sensor's alerts) with a circle, with a note that can use what came in ({{ event.object.subject }}). It asks first, unless the person lets that node run on its own. It shares as the automation's owner, only what they can see in the automation's namespaces, and never from a vault.

How: app/domain/actions_circles.py registers the action with an outside effect (so it asks by default) and calls circles.share with the owner as the sharer.

Motivation and Context

Third agent family network PR: "my agent sees the school email and tells my son" without me clicking each time.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change; ! in the title)

Checklist:

  • The title is a Conventional Commit.
  • My code follows the code style of this project (make hooks checks it on commit).
  • I added or updated tests.
  • My change requires documentation updates, and I have updated docs/ accordingly.
  • Users need more than the title to understand it, so I wrote it in changelog.d/circles-rules.md.

Done questions (AGENTS.md)

  • Goal: merges on green CI (pending).
  • Agents: agents build automations with it through the automations API and MCP tools.
  • Zero setup: nothing new to install.
  • Fewest clicks: one action card in the automation builder.
  • Configurable: n/a, no new settings.
  • Light: no new dependency.
  • Private and secure: shares only what the owner can see, never a vault; P-CIRCLES updated.
  • Cost: no model calls.
  • User decides: asks first until the person lets the node run on its own.
  • Upgrades: no stored-data changes.
  • Honest: README and requirements updated.
  • Tests (tests/api/test_circles.py) and docs (docs/circles.md#rules, automations).
  • Open standards: n/a.
  • Reported in the project thread.
  • Reuse: the action registry and approvals.

Generated by Claude Code

@adeelahmad
adeelahmad merged commit 2d3821a into main Oct 19, 2026
12 checks passed
@adeelahmad
adeelahmad deleted the claude/project-thread-97gkhw branch October 19, 2026 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0