8000 feat(circles): circles under Profile and a Share action in the web app by adeelahmad · Pull Request #649 · adeelahmad/lense · GitHub
[go: up one dir, main page]

Skip to content

feat(circles): circles under Profile and a Share action in the web app - #649

Merged
adeelahmad merged 1 commit into
mainfrom
claude/project-thread-97gkhw
Oct 19, 2026
Merged

adeelahmad merged 1 commit into
mainfrom
claude/project-thread-97gkhw

Conversation

@adeelahmad
Copy link
Copy Markdown
Owner

Requested by Adeel · project thread

Description

Before: circles of trust and sharing (#626) worked only through the API, MCP and the assistant.

After: your circles are under Profile. A suggested name makes a circle in one click, people are added from a list and removed with ×, and deleting a circle is undone from its toast. Share on a timeline item, or Share with a circle… in a resource's menu, picks your only circle, takes a note, and is undone from its toast. Shares show under Shared in the timeline filters.

How: components/account/circles.tsx (Profile panel), components/circles/share-dialog.tsx and model.ts, wired into the timeline item and the recording header, using the generated client from #626.

Motivation and Context

Second of the agent family network PRs; follows #626.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change; ! in the title)

Checklist:

  • The title is a Conventional Commit.
  • My code follows the code style of this project (make hooks checks it on commit).
  • I added or updated tests.
  • My change requires documentation updates, and I have updated docs/ accordingly.
  • Users need more than the title to understand it, so I wrote it in changelog.d/circles-web.md.

Done questions (AGENTS.md)

  • Goal: merges on green CI (pending).
  • Agents: n/a for new surface, since the same actions were already in the API, MCP and the assistant (feat(circles): circles of trust and sharing with them, with API and MCP #626).
  • Zero setup: nothing new to install or configure.
  • Fewest clicks: suggested names make a circle in one click, the only circle is pre-picked, Enter submits, undo instead of confirm.
  • Configurable: n/a, no new settings.
  • Light: frontend only.
  • Private and secure: n/a, no new server surface; the threat model's P-CIRCLES covers sharing.
  • Cost: no model calls.
  • User decides: sharing happens only on the person's click.
  • Upgrades: no stored-data changes.
  • Honest: README moves the web app from planned to built.
  • Tests (__tests__/circles-ui.test.tsx) 8000 and docs (docs/circles.md, docs/timeline.md, requirements).
  • Open standards: n/a.
  • Reported in the project thread.
  • Reuse: existing dialog, toast and timeline components.

Generated by Claude Code

@adeelahmad
adeelahmad merged commit 108c96f into main Oct 19, 2026
10 checks passed
@adeelahmad
adeelahmad deleted the claude/project-thread-97gkhw branch October 19, 2026 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0