Repository navigation
test: keep the scaling schedule and setup assistant tests green on main - #648
Merged
Merged
Conversation
The scaling schedule test fixed its own clock at 2026-10-18 12:00 but the group was stamped with the real time, so once real time passed 18:00 on that day the schedule's next fire moved to tomorrow and the test failed. It now stamps the group with the test's clock. The setup conversation test read server_status's whole JSON from what the model was sent. The budgets and circles tools made the setup tool list long enough that, at the default 16k window, chat.fit cut that result in the middle. The test now gives the model room for every result. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01291QUFHs51wLhGQwp2DAh9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before: main's backend CI is red. Two tests fail in all four FastAPI jobs:
test_rules_scale_on_waiting_jobs_and_on_a_scheduleandtest_a_setup_conversation_sets_the_server_up. That blocks the next release.After: both pass. Only tests change.
Motivation and Context
0 18 * * *fire moved to tomorrow, and the 18:01 tick stopped firing. The test now stamps the group with its own clock. It started failing on main at 18:00 UTC today, after e6e96ba had passed.server_status's whole JSON from what the model was sent. The newbudgetstool (feat(budgets): the assistant and agents answer where budgets stand #645) andcirclestool (feat(circles): circles of trust and sharing with them, with API and MCP #626) made the setup tool list long enough that, at the default 16k window,chat.fitcuts that result in the middle, so it no longer parses. The test now gives the model a 128k default window, so every result fits. Cutting results to fit a small window is intended and unchanged.Both failures reproduce locally on main and pass with this change (
pytest tests/api/test_scaling.py tests/api/test_setup_assistant.py: 19 passed).Types of changes
Checklist:
Done questions (AGENTS.md)
Generated by Claude Code