Repository navigation
feat(pipelines): a Read step picks its own converter, such as anytopdf - #610
Merged
Merged
Conversation
A pipeline's read step takes converter (auto, anytopdf or lens) in place of documents.converter, so one pipeline can make its PDFs with anytopdf while the rest keep the server's choice. The pipeline editor shows it as Make PDFs with. An image read again by Lens itself no longer keeps a stale anytopdf rendition. DEVLOG's anytopdf entry now says what is built and what is left. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ChKkay74tsVsqnBCyksvoW
…-vtz8ka # Conflicts: # README.md # fastapi_backend/app/domain/pipelines.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Adeel · project thread
Description
Before: whether anytopdf makes a document's PDF was one server-wide choice (
documents.converter). A pipeline for scanned receipts couldn't use anytopdf (with its page flattening) while the rest of the archive kept Lens's own converters. Re-reading an image with Lens after anytopdf had read it left the asset pointing at the old anytopdf PDF.After: a pipeline's Read step takes
converter(auto,anytopdforlens), shown in the pipeline editor as Make PDFs with; unset follows Settings › Documents. If the step asks for anytopdf where it isn't installed and no conversion node is set, Lens converts the file and the run log says why. An image read by Lens itself clears its stale rendition. DEVLOG's anytopdf entry (from #120, still saying "not started") now lists what's built and what's left.How:
pipelines.validate_stepsacceptsconverteronly on a read step and checks its value;jobs._readrunsdocuments.transcribewith that converter in place ofdocuments.converter; no stored-data shape changes.Motivation and Context
The anytopdf integration backlog item (#120). Most of it shipped already (#210 #220 #222 #223 #226 #229 #233); the open "Convert with anytopdf node with its options" item is this.
Types of changes
Checklist:
test_a_read_step_picks_its_own_converter,pipeline-convert.test.ts).docs/(processing.md, configuration.md, requirements.md, README).changelog.d/read-step-converter.md.Local CI:
ci/local-ci.sh --jobs backendpassed on 3c4cd56; frontend jest for the changed test, tsc, eslint, prettier, ruff andcheck_requirements.pypass.Done questions
POST/PATCH /api/v1/pipelineswith{"type": "read", "converter": "anytopdf"}, andPOST /api/v1/jobswith steps.converter).documents.converterlogic, only overriding it per step.Generated by Claude Code