Repository navigation
fix(automations): a run's trace marks an action that waits as waiting, not done - #586
Merged
Merged
Conversation
…, not done An action that asks first or waits for its time passed nothing on, and the workflow engine called its node done. finish() now marks it waiting or scheduled, and the canvas shows those as would ask you first / would wait for its time. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AjJqXgjj1cNdKGRQbX5frb
19 of 23 tasks
70CF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Adeel · project thread
Description
Before: an action that asks first (posting to the family room) or waits for its time passed nothing on, so the workflow engine marked its node
donein the run's trace. The canvas showed a green dot for a post that had not been sent.After: the trace marks such a node
waiting(asks first) orscheduled(waits for its time). The canvas draws them with a gold dot titled "Would ask you first in the last try" or "Would wait for its time in the last try", and the node's settings say so too.Motivation and Context
Found while writing the M12 journey test (email → approval → timeline): the run's own status was
waiting, but its trace said the waiting node was done. Workflow studio M11/M12.Types of changes
!in the title)Checklist:
make hookschecks it on commit).test_automation_nodes.py,test_automation_runs.pynow assertwaitingandscheduled).docs/automations.mdlists the trace statuses.Local CI (
ci/local-ci.sh HEAD --jobs backend,server,frontend,pre-commit): FastAPI embedded pass, FastAPI server pass, Next.js pass, pre-commit pass.Done questions (AGENTS.md)
Generated by Claude Code